Merge lp:~huwshimi/launchpad/hover-row-43231 into lp:launchpad

[Huw Wilkins]

Table listing rows now highlight when hovered.

Added a highlight when you hover a row on a table listing.

TO TEST:
Find a table listing (such as https://bugs.launchpad.dev/ubuntu or https://answers.launchpad.dev/ubuntu). Hover a row with your mouse and the background of that row should change to a pale grey.

[Martin Pool (mbp)]

I'll just note there is already a hover that produces an underline on
the link to the bug itself (or whatever). I feel it is an antipattern
to have a hover highlight region that is larger than the actually
sensitive region, and this patch would do that. (hraspace is a very
good example of why this is bad.) It's true that the bugzilla theme
cited as an example in the bug does have the same behaviour but I'm
not sure I like it there.

The general skin of Launchpad has changed since this bug was
originally filed, so assertions made then about usability aren't
necessarily true. Personally I feel the dotted lines between rows
give good unity without being as heavy as a hover highlight. Are
there still people who feel otherwise? Unless this actually aids
usability I think we should leave it out.

[Graham Binns (gmb)]

I can approve the code for this, but I'm not a UI reviewer, so I've added a request for a UI review.

review: Approve (code)

[Curtis Hovey (sinzui)]

I have trouble seeing the background colour (#f6f6f6) on LCD displays. The difference
in colour is less that the variation in brightness from the top and bottom angles. I can see the colour change when I hover over a row at the top of my screen, but I cannot see it if the row is at the bottom on my screen. I think the CSS has a lot of disagreement about the hex value for a background colour:

    The app links use #747474
    The involvement links use #eee
    Latests PPA updates alternates odd-even #fff-#eeeeff

And I see that #f6f6f6 is also by a class so I do not think users will see the update
on hover:

    .shaded rows use #f6f6f6

There are some unwanted interactions with this new rule, but I think this maybe case where the rule is write, and we have some pages that need fixing:

Heading rows (tr th) in the body are made /lighter/ on hover:
    https://launchpad.dev/ubuntu/+cdmirrors

Empty rows in poorly constructed table highlight nothing:
    https://launchpad.dev/ubuntu/+source/pmount

review: Needs Information

=== modified file 'lib/canonical/launchpad/icing/style-3-0.css.in'
--- lib/canonical/launchpad/icing/style-3-0.css.in	2011-02-03 21:08:58 +0000
+++ lib/canonical/launchpad/icing/style-3-0.css.in	2011-02-08 06:03:16 +0000
@@ -637,6 +637,9 @@
 table.listing, table.listing tbody, table.listing td.end-of-section {
     border-bottom: 1px solid #d2d2d2;
     }
+table.listing tr:hover {
+    background-color: #f6f6f6;
+    }
 table.listing th {
     font-weight: bold;
     }