Reviewers: mp+175211_code.launchpad.net,
Message: Please take a look.
Description: Fix presentation issues in IE10
FIXES: - Charm details last tabs wrapping onto new line. - Charmtoken icons stretching on screen - they are new clipped in some cases, but this also solves issues with additional scrollbars appearing.
https://code.launchpad.net/~huwshimi/juju-gui/ie-fixes/+merge/175211
(do not edit description out of merge proposal)
Please review this at https://codereview.appspot.com/11431043/
Affected files: A [revision details] M lib/views/browser/charm-full.less M lib/views/browser/charm-token.less
Index: [revision details] === added file '[revision details]' --- [revision details] 2012-01-01 00:00:00 +0000 +++ [revision details] 2012-01-01 00:00:00 +0000 @@ -0,0 +1,2 @@ +Old revision: <email address hidden> +New revision: <email address hidden>
Index: lib/views/browser/charm-full.less === modified file 'lib/views/browser/charm-full.less' --- lib/views/browser/charm-full.less 2013-07-16 20:09:51 +0000 +++ lib/views/browser/charm-full.less 2013-07-17 07:26:54 +0000 @@ -35,7 +35,7 @@ padding: 0 70px 0 80px; } .yui3-tabview-list { - width: 590px; + padding-right: 20px; } .yui3-tabview-panel { .border-box;
Index: lib/views/browser/charm-token.less === modified file 'lib/views/browser/charm-token.less' --- lib/views/browser/charm-token.less 2013-07-16 14:25:33 +0000 +++ lib/views/browser/charm-token.less 2013-07-17 07:26:54 +0000 @@ -15,10 +15,17 @@ .charm-icon, .category-icon, .icon { + margin-right: 12px; + position: relative; + } + .charm-icon, + .charm-icon img, + .category-icon, + .category-icon img, + .icon, + .icon img { width: 48px; height: 48px; - margin-right: 12px; - position: relative; } .charm-icon { background: transparent @@ -34,10 +41,17 @@ .charm-icon, .category-icon, .icon { + margin-right: 10px; + position: relative; + } + .charm-icon, + .charm-icon img, + .category-icon, + .category-icon img, + .icon, + .icon img { width: 50px; height: 50px; - margin-right: 10px; - position: relative; } .charm-icon { background: transparent @@ -49,10 +63,17 @@ .charm-icon, .category-icon, .icon { + margin-right: 16px; + position: relative; + } + .charm-icon, + .charm-icon img, + .category-icon, + .category-icon img, + .icon, + .icon img { width: 96px; height: 96px; - margin-right: 16px; - position: relative; } .charm-icon { background: transparent
« Back to merge proposal
Reviewers: mp+175211_ code.launchpad. net,
Message:
Please take a look.
Description:
Fix presentation issues in IE10
FIXES:
- Charm details last tabs wrapping onto new line.
- Charmtoken icons stretching on screen - they are new clipped in some
cases,
but this also solves issues with additional scrollbars appearing.
https:/ /code.launchpad .net/~huwshimi/ juju-gui/ ie-fixes/ +merge/ 175211
(do not edit description out of merge proposal)
Please review this at https:/ /codereview. appspot. com/11431043/
Affected files: browser/ charm-full. less browser/ charm-token. less
A [revision details]
M lib/views/
M lib/views/
Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: <email address hidden>
+New revision: <email address hidden>
Index: lib/views/ browser/ charm-full. less browser/ charm-full. less' browser/ charm-full. less 2013-07-16 20:09:51 +0000 browser/ charm-full. less 2013-07-17 07:26:54 +0000 yui3-tabview- list { yui3-tabview- panel {
.border- box;
=== modified file 'lib/views/
--- lib/views/
+++ lib/views/
@@ -35,7 +35,7 @@
padding: 0 70px 0 80px;
}
.
- width: 590px;
+ padding-right: 20px;
}
.
Index: lib/views/ browser/ charm-token. less browser/ charm-token. less' browser/ charm-token. less 2013-07-16 14:25:33 +0000 browser/ charm-token. less 2013-07-17 07:26:54 +0000
.charm- icon,
.category- icon,
width: 48px;
height: 48px;
.charm- icon {
background: transparent
.charm- icon,
.category- icon,
width: 50px;
height: 50px;
.charm- icon {
background: transparent
.charm- icon,
.category- icon,
width: 96px;
height: 96px;
.charm- icon {
background: transparent
=== modified file 'lib/views/
--- lib/views/
+++ lib/views/
@@ -15,10 +15,17 @@
.icon {
+ margin-right: 12px;
+ position: relative;
+ }
+ .charm-icon,
+ .charm-icon img,
+ .category-icon,
+ .category-icon img,
+ .icon,
+ .icon img {
- margin-right: 12px;
- position: relative;
}
@@ -34,10 +41,17 @@
.icon {
+ margin-right: 10px;
+ position: relative;
+ }
+ .charm-icon,
+ .charm-icon img,
+ .category-icon,
+ .category-icon img,
+ .icon,
+ .icon img {
- margin-right: 10px;
- position: relative;
}
@@ -49,10 +63,17 @@
.icon {
+ margin-right: 16px;
+ position: relative;
+ }
+ .charm-icon,
+ .charm-icon img,
+ .category-icon,
+ .category-icon img,
+ .icon,
+ .icon img {
- margin-right: 16px;
- position: relative;
}