juju-gui

Merge lp:~huwshimi/juju-gui/ie-fixes into lp:juju-gui/experimental

  1. ie-fixes
  2. Merge into trunk
Proposed by Huw Wilkins
Status: Merged
Merged at revision: 866
Proposed branch: lp:~huwshimi/juju-gui/ie-fixes
Merge into: lp:juju-gui/experimental
Diff against target: 76 lines (+28/-7)
2 files modified
lib/views/browser/charm-full.less (+1/-1)
lib/views/browser/charm-token.less (+27/-6)
To merge this branch: bzr merge lp:~huwshimi/juju-gui/ie-fixes
Reviewer Review Type Date Requested Status
Juju GUI Hackers Pending
Review via email: mp+175211@code.launchpad.net

Description of the change

Fix presentation issues in IE10

FIXES:
- Charm details last tabs wrapping onto new line.
- Charmtoken icons stretching on screen - they are new clipped in some cases,
but this also solves issues with additional scrollbars appearing.

https://codereview.appspot.com/11431043/

To post a comment you must log in.
Revision history for this message
Huw Wilkins (huwshimi) wrote :
Download full text (3.2 KiB)

Reviewers: mp+175211_code.launchpad.net,

Message:
Please take a look.

Description:
Fix presentation issues in IE10

FIXES:
- Charm details last tabs wrapping onto new line.
- Charmtoken icons stretching on screen - they are new clipped in some
cases,
but this also solves issues with additional scrollbars appearing.

https://code.launchpad.net/~huwshimi/juju-gui/ie-fixes/+merge/175211

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/11431043/

Affected files:
   A [revision details]
   M lib/views/browser/charm-full.less
   M lib/views/browser/charm-token.less

Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: <email address hidden>
+New revision: <email address hidden>

Index: lib/views/browser/charm-full.less
=== modified file 'lib/views/browser/charm-full.less'
--- lib/views/browser/charm-full.less 2013-07-16 20:09:51 +0000
+++ lib/views/browser/charm-full.less 2013-07-17 07:26:54 +0000
@@ -35,7 +35,7 @@
          padding: 0 70px 0 80px;
      }
      .yui3-tabview-list {
- width: 590px;
+ padding-right: 20px;
      }
      .yui3-tabview-panel {
          .border-box;

Index: lib/views/browser/charm-token.less
=== modified file 'lib/views/browser/charm-token.less'
--- lib/views/browser/charm-token.less 2013-07-16 14:25:33 +0000
+++ lib/views/browser/charm-token.less 2013-07-17 07:26:54 +0000
@@ -15,10 +15,17 @@
              .charm-icon,
              .category-icon,
              .icon {
+ margin-right: 12px;
+ position: relative;
+ }
+ .charm-icon,
+ .charm-icon img,
+ .category-icon,
+ .category-icon img,
+ .icon,
+ .icon img {
                  width: 48px;
                  height: 48px;
- margin-right: 12px;
- position: relative;
              }
              .charm-icon {
                  background: transparent
@@ -34,10 +41,17 @@
              .charm-icon,
              .category-icon,
              .icon {
+ margin-right: 10px;
+ position: relative;
+ }
+ .charm-icon,
+ .charm-icon img,
+ .category-icon,
+ .category-icon img,
+ .icon,
+ .icon img {
                  width: 50px;
                  height: 50px;
- margin-right: 10px;
- position: relative;
              }
              .charm-icon {
                  background: transparent
@@ -49,10 +63,17 @@
              .charm-icon,
              .category-icon,
              .icon {
+ margin-right: 16px;
+ position: relative;
+ }
+ .charm-icon,
+ .charm-icon img,
+ .category-icon,
+ .category-icon img,
+ .icon,
+ .icon img {
                  width: 96px;
                  height: 96px;
- margin-right: 16px;
- ...

Read more...

Revision history for this message
Gary Poster (gary) wrote :

LGTM. I don't have an IE on my laptop, but it looks fine on Chrome and
Firefox

https://codereview.appspot.com/11431043/

Revision history for this message
Gary Poster (gary) wrote :

*** Submitted:

Fix presentation issues in IE10

FIXES:
- Charm details last tabs wrapping onto new line.
- Charmtoken icons stretching on screen - they are new clipped in some
cases,
but this also solves issues with additional scrollbars appearing.

R=gary.poster
CC=
https://codereview.appspot.com/11431043

https://codereview.appspot.com/11431043/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/views/browser/charm-full.less'
2--- lib/views/browser/charm-full.less 2013-07-16 20:09:51 +0000
3+++ lib/views/browser/charm-full.less 2013-07-17 07:36:43 +0000
4@@ -35,7 +35,7 @@
5 padding: 0 70px 0 80px;
6 }
7 .yui3-tabview-list {
8- width: 590px;
9+ padding-right: 20px;
10 }
11 .yui3-tabview-panel {
12 .border-box;
13
14=== modified file 'lib/views/browser/charm-token.less'
15--- lib/views/browser/charm-token.less 2013-07-16 14:25:33 +0000
16+++ lib/views/browser/charm-token.less 2013-07-17 07:36:43 +0000
17@@ -15,10 +15,17 @@
18 .charm-icon,
19 .category-icon,
20 .icon {
21+ margin-right: 12px;
22+ position: relative;
23+ }
24+ .charm-icon,
25+ .charm-icon img,
26+ .category-icon,
27+ .category-icon img,
28+ .icon,
29+ .icon img {
30 width: 48px;
31 height: 48px;
32- margin-right: 12px;
33- position: relative;
34 }
35 .charm-icon {
36 background: transparent
37@@ -34,10 +41,17 @@
38 .charm-icon,
39 .category-icon,
40 .icon {
41+ margin-right: 10px;
42+ position: relative;
43+ }
44+ .charm-icon,
45+ .charm-icon img,
46+ .category-icon,
47+ .category-icon img,
48+ .icon,
49+ .icon img {
50 width: 50px;
51 height: 50px;
52- margin-right: 10px;
53- position: relative;
54 }
55 .charm-icon {
56 background: transparent
57@@ -49,10 +63,17 @@
58 .charm-icon,
59 .category-icon,
60 .icon {
61+ margin-right: 16px;
62+ position: relative;
63+ }
64+ .charm-icon,
65+ .charm-icon img,
66+ .category-icon,
67+ .category-icon img,
68+ .icon,
69+ .icon img {
70 width: 96px;
71 height: 96px;
72- margin-right: 16px;
73- position: relative;
74 }
75 .charm-icon {
76 background: transparent

Subscribers

People subscribed via source and target branches