Code review comment for lp:~hrvojem/percona-xtrabackup/bug924313

Alexey Kopytov (akopytov) wrote :

Looks good, except that the request in bug #924313 was that we make it clear from our documentation that we don't currently support streaming incremental backups. That is, --incremental, --incremental-basedir and --incremental-lsn are ignored when --stream is specified on the innobackupex command line.

I suggest we mention that in the corresponding options descriptions in http://www.percona.com/doc/percona-xtrabackup/innobackupex/innobackupex_option_reference.html and in http://www.percona.com/doc/percona-xtrabackup/innobackupex/streaming_backups_innobackupex.html

Please also not that we are going to fix this in 1.9.1. And that's the first case when the manual will get out of sync with 1.6. I'm not sure what to do about that. We can either create a separate 1.6 manual, or just ignore it and say that the online XtraBackup docs describe only 2.0.

review: Needs Fixing

« Back to merge proposal