Merge lp:~hrvojem/percona-xtrabackup/bug924313 into lp:percona-xtrabackup/2.0

Proposed by Hrvoje Matijakovic on 2012-02-13
Status: Merged
Approved by: Alexey Kopytov on 2012-02-14
Approved revision: 389
Merged at revision: 391
Proposed branch: lp:~hrvojem/percona-xtrabackup/bug924313
Merge into: lp:percona-xtrabackup/2.0
Diff against target: 82 lines (+8/-6)
5 files modified
doc/source/conf.py (+1/-1)
doc/source/innobackupex/how_innobackupex_works.rst (+1/-1)
doc/source/innobackupex/innobackupex_option_reference.rst (+3/-3)
doc/source/innobackupex/streaming_backups_innobackupex.rst (+2/-0)
src/xtrabackup.c (+1/-1)
To merge this branch: bzr merge lp:~hrvojem/percona-xtrabackup/bug924313
Reviewer Review Type Date Requested Status
Alexey Kopytov (community) 2012-02-13 Approve on 2012-02-14
Review via email: mp+92772@code.launchpad.net
To post a comment you must log in.
Alexey Kopytov (akopytov) wrote :

Looks good, except that the request in bug #924313 was that we make it clear from our documentation that we don't currently support streaming incremental backups. That is, --incremental, --incremental-basedir and --incremental-lsn are ignored when --stream is specified on the innobackupex command line.

I suggest we mention that in the corresponding options descriptions in http://www.percona.com/doc/percona-xtrabackup/innobackupex/innobackupex_option_reference.html and in http://www.percona.com/doc/percona-xtrabackup/innobackupex/streaming_backups_innobackupex.html

Please also not that we are going to fix this in 1.9.1. And that's the first case when the manual will get out of sync with 1.6. I'm not sure what to do about that. We can either create a separate 1.6 manual, or just ignore it and say that the online XtraBackup docs describe only 2.0.

review: Needs Fixing
Stewart Smith (stewart) wrote :

On Mon, 13 Feb 2012 15:32:02 -0000, Alexey Kopytov <email address hidden> wrote:
> Please also not that we are going to fix this in 1.9.1. And that's the
> first case when the manual will get out of sync with 1.6. I'm not sure
> what to do about that. We can either create a separate 1.6 manual, or
> just ignore it and say that the online XtraBackup docs describe only
> 2.0.

This is a good question.... and one that (as you may have noticed) I've
rather successfully delayed :)

My current thought is that we note which parts are applicable only to
2.0 or 1.6 and with the major release following 2.0 we split it off.

--
Stewart Smith

Alexey Kopytov (akopytov) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'doc/source/conf.py'
2--- doc/source/conf.py 2012-02-08 15:08:50 +0000
3+++ doc/source/conf.py 2012-02-14 08:36:17 +0000
4@@ -53,7 +53,7 @@
5 # The short X.Y version.
6 version = '1.6'
7 # The full version, including alpha/beta/rc tags.
8-release = '2'
9+release = '5'
10
11 # The language for content autogenerated by Sphinx. Refer to documentation
12 # for a list of supported languages.
13
14=== modified file 'doc/source/innobackupex/how_innobackupex_works.rst'
15--- doc/source/innobackupex/how_innobackupex_works.rst 2011-10-24 18:37:06 +0000
16+++ doc/source/innobackupex/how_innobackupex_works.rst 2012-02-14 08:36:17 +0000
17@@ -53,7 +53,7 @@
18 :file:`mysql-stdout`
19 containing the ``STDOUT`` of the server.
20
21-If the :option:`--remote-host` was set, |innobackupex| will test the connection to the host via :command:`ssh` and create the backup directories. Then the same process will be applied but the log will be written to a temporary file and will be copied via :command:`scp` with the options set by :option:`--options-scp` (``-Cp -c arcfour`` by default).
22+If the :option:`--remote-host` was set, |innobackupex| will test the connection to the host via :command:`ssh` and create the backup directories. Then the same process will be applied but the log will be written to a temporary file and will be copied via :command:`scp` with the options set by :option:`--scpopt` (``-Cp -c arcfour`` by default).
23
24 After each copy the files will be deleted. The same rationale is for the :option:`--stream` mode.
25
26
27=== modified file 'doc/source/innobackupex/innobackupex_option_reference.rst'
28--- doc/source/innobackupex/innobackupex_option_reference.rst 2012-02-02 20:24:24 +0000
29+++ doc/source/innobackupex/innobackupex_option_reference.rst 2012-02-14 08:36:17 +0000
30@@ -109,7 +109,7 @@
31
32 .. option:: --incremental-lsn
33
34- This option accepts a string argument that specifies the log sequence number (:term:`LSN`) to use for the incremental backup. It is used with the :option:`--incremental` option. It is used instead of specifying :option:`--incremental-basedir`. For databases created by *MySQL* and *Percona Server* 5.0-series versions, specify the as two 32-bit integers in high:low format. For databases created in 5.1 and later, specify the LSN as a single 64-bit integer.
35+ This option accepts a string argument that specifies the log sequence number (:term:`LSN`) to use for the incremental backup. It is used with the :option:`--incremental` option. It is used instead of specifying :option:`--incremental-basedir`. For databases created by *MySQL* and *Percona Server* 5.0-series versions, specify the as two 32-bit integers in high:low format. For databases created in 5.1 and later, specify the LSN as a single 64-bit integer.
36
37 .. option:: --extra-lsndir
38
39@@ -121,7 +121,7 @@
40
41 .. option:: --stream
42
43- This option accepts a string argument that specifies the format in which to do the streamed backup. The backup will be done to ``STDOUT`` in the specified format. Currently, the only supported format is :command:`tar`. Uses :doc:`tar4ibd <../tar4ibd/tar4ibd_binary>`, which is available in *XtraBackup* distributions. If you specify a path after this option, it will be interpreted as the value of :option:`tmpdir`.
44+ This option accepts a string argument that specifies the format in which to do the streamed backup. The backup will be done to ``STDOUT`` in the specified format. Currently, the only supported format is :command:`tar`. Uses :doc:`tar4ibd <../tar4ibd/tar4ibd_binary>`, which is available in *XtraBackup* distributions. If you specify a path after this option, it will be interpreted as the value of :option:`tmpdir`. If both :option:`--stream` and :option:`--incremental` are passed to innobackupex, the incremental parameters are ignored and a full backup is created.
45
46 .. option:: --tmpdir
47
48@@ -135,7 +135,7 @@
49
50 This option forces the use of :command:`tar` when creating a streamed backup, rather than :program:`tar4ibd`, which is the default.
51
52-.. option:: --scp-opt = '-Cp -c arcfour'
53+.. option:: --scpopt = '-Cp -c arcfour'
54
55 This option accepts a string argument that specifies the command line options to pass to :command:`scp` when the option :option:`--remost-host` is specified. If the option is not specified, the default options are ``-Cp -c arcfour``.
56
57
58=== modified file 'doc/source/innobackupex/streaming_backups_innobackupex.rst'
59--- doc/source/innobackupex/streaming_backups_innobackupex.rst 2011-09-28 01:11:16 +0000
60+++ doc/source/innobackupex/streaming_backups_innobackupex.rst 2012-02-14 08:36:17 +0000
61@@ -6,6 +6,8 @@
62
63 This allows to pipe the stream to other programs, providing great flexibility to the output of it. For example, compression is achieved by piping the output to a compression utility.
64
65+.. warning:: If both --stream and --incremental are passed to innobackupex, the incremental parameters are ignored and a full backup is created.
66+
67 To use this feature, you must use the :option:`--stream`, providing the format of the stream (only ``tar`` is supported at this moment) and where should the store the temporary files::
68
69 $ innobackupex --stream=tar /tmp
70
71=== modified file 'src/xtrabackup.c'
72--- src/xtrabackup.c 2012-02-10 20:05:56 +0000
73+++ src/xtrabackup.c 2012-02-14 08:36:17 +0000
74@@ -1036,7 +1036,7 @@
75 {"extra-lsndir", OPT_XTRA_EXTRA_LSNDIR, "(for --backup): save an extra copy of the xtrabackup_checkpoints file in this directory.",
76 (G_PTR*) &xtrabackup_extra_lsndir, (G_PTR*) &xtrabackup_extra_lsndir,
77 0, GET_STR, REQUIRED_ARG, 0, 0, 0, 0, 0, 0},
78- {"incremental-lsn", OPT_XTRA_INCREMENTAL, "(for --backup): copy only .ibd pages newer than specified LSN 'high:low'. ##ATTENTION##: checkpoint lsn must be used. anyone can detect your mistake. be carefully!",
79+ {"incremental-lsn", OPT_XTRA_INCREMENTAL, "(for --backup): copy only .ibd pages newer than specified LSN 'high:low'. ##ATTENTION##: If a wrong LSN value is specified, it is impossible to diagnose this, causing the backup to be unusable. Be careful!",
80 (G_PTR*) &xtrabackup_incremental, (G_PTR*) &xtrabackup_incremental,
81 0, GET_STR, REQUIRED_ARG, 0, 0, 0, 0, 0, 0},
82 {"incremental-basedir", OPT_XTRA_INCREMENTAL_BASEDIR, "(for --backup): copy only .ibd pages newer than backup at specified directory.",

Subscribers

People subscribed via source and target branches