Code review comment for lp:~hrvojem/percona-xtrabackup/bug1008826

Revision history for this message
Alexey Kopytov (akopytov) wrote :

Hrvoje,

- The doc says mentions that the partial backups feature "has the
  limitation of not being supported with streaming". That statement is
  either incorrect or obsolete. I understand it's been
  copied from the partial backups page, and have filed a separate bug
  report on it: bug #1052784. But the --include option which is used for
  examples in this MP should work fine with streaming

- it may not be clear where this "^imdb[.]name#P#p4" expression came
  from. it would be good to explain that "imdb.name#P#p4" is the name of
  the table corresponding to partition 'p4' of table 'name' located in
  the imdb database.

- small things:
  s/There shouldn't be no/There should be no/
  s/`nnodb_import_table_from_xtrabackup`/`innodb_import_table_from_xtrabackup`/

review: Needs Fixing

« Back to merge proposal