Code review comment for lp:~hipl-core/hipl/libhip

Revision history for this message
Diego Biurrun (diego-biurrun) wrote :

 review approve

On Tue, May 15, 2012 at 09:26:17AM +0000, Xin wrote:
> Xin has proposed merging lp:~hipl-core/hipl/libhip into lp:hipl.
>
> --- Makefile.am 2012-05-12 06:54:33 +0000
> +++ Makefile.am 2012-05-15 09:25:24 +0000
> @@ -66,10 +67,14 @@
> TESTS = test/check_hipd \
> test/check_hipfw \
> test/check_libcore \
> + test/check_libhipl \
> + test/check_libcore \
> $(tools_hipdnsproxy_PYTHON)
> +

order

Please fix this before merging.

I don't have time to go through this again in the short-term future,
so let's get this merged and work on the details later.

Diego

review: Approve

« Back to merge proposal