Code review comment for lp:~hipl-core/hipl/libhip

Revision history for this message
Xin (eric-nevup) wrote :

Hi,

On 12/05/12 14:00, Diego Biurrun wrote:
> On Sat, May 12, 2012 at 10:13:17AM +0300, Xin Gu wrote:
>> On 11/05/12 00:55, Diego Biurrun wrote:
>>>> @@ -202,6 +166,47 @@
>>>>
>>>> +lib_hipl_libhipl_la_SOURCES = lib/hipl/accessor.c \
>>>> + lib/hipl/lhipl.c \
>>>> + lib/hipl/lhipl_sock.c \
>>>> + lib/hipl/lhipl_operations.c \
>>> Why this lhipl prefix?
>> It is a short form for libhipl. This prefix can help to identify src
>> code files related to libhipl.
> There is no need to identify files in the libhipl directory as belonging
> to libhipl. What else would they belong to? We don't have hipfw_ and
> hipd_ prefixes in the hipd/ and hipfw/ directories.
>

I was not so clear in previous reply. This prefix aims to identify src
code files related to library-based HIP.

Xin

« Back to merge proposal