Code review comment for lp:~hipl-core/hipl/android-hipfw

On 01.09.2014, at 14:14, Juhani Toivonen <email address hidden> wrote:

> On 01.09.2014, at 00:10, Diego Biurrun <email address hidden> wrote:
>
>>>> I fully agree with René, these inline patches are ugly.
>>>
>>> Fine, I’ll find a place to host them and have the script pull them in.
>>
>> You don't need to. Adding the files to HIPL is not a problem, but why
>> have them inlined into the script?
>>
>> Diego
>>
>
> I have now fixed all the other parts except Rene’s suggestion to remove the CC, CFLAGS etc. from the configure command-line.
> I haven’t figured out what goes wrong with that yet. I’m guessing the environment variables are not being resolved correctly when left to just the configure.ac
>
>
> $ ./configure --enable-android --host=arm-linux --prefix=/usr --sysconfdir=/etc
> . . .
>
> $ make
> make all-am
> make[1]: Entering directory `/android/src/android-hipfw'
> CC libcore/builder.lo
> libcore/builder.c: Assembler messages:
> libcore/builder.c:144: Error: no such instruction: `rev %edx,%edx'
> libcore/builder.c:133: Error: no such instruction: `rev16 %dx,%dx'
> libcore/builder.c:137: Error: no such instruction: `rev16 %dx,%dx'
> libcore/builder.c:148: Error: no such instruction: `rev %edx,%edx'
> libcore/builder.c:410: Error: no such instruction: `rev16 %dx,%dx'
> libcore/builder.c:410: Error: no such instruction: `rev16 %ax,%ax'
> libcore/builder.c:166: Error: no such instruction: `rev16 %dx,%dx'
> libcore/builder.c:172: Error: no such instruction: `rev16 %dx,%dx'
> libcore/builder.c:424: Error: no such instruction: `rev16 %ax,%ax’
> . . .

Nevermind. It didn’t know which CC to use. Working on fixing it now.