Code review comment for lp:~hipl-core/hipl/android-hipfw

Revision history for this message
René Hummen (rene-hummen) wrote :

I agree with Miika that the patches should be separated from 'tools/prepare_android_toolchain.sh'. Probably, you could even download them in your script. We then would not need to include external code in our repository.

In addition, please see my two diff comments.

review: Needs Fixing

« Back to merge proposal