Code review comment for lp:~hingo/drizzle/drizzle-execute-result_set-off-by-one

Revision history for this message
Mark Atwood (fallenpegasus) wrote :

Turns out it does fail in a test

http://jenkins.drizzle.org/view/Drizzle-build/job/drizzle-build-ubuntu10.10-32bit/1151/console

json_server.basic [ fail ]
--- ../plugin/json_server/tests/r/basic.result 2011-12-28 05:06:28.000000000 +0300
+++ /home/hudson/hudson/workspace/drizzle-build-ubuntu10.10-32bit/drizzle7-2011.11.29.2480/_build/tests/var/log/basic.reject 2011-12-28 05:29:35.000000000 +0300
@@ -3,9 +3,6 @@
 http_post("http://localhost:PORT/0.1/sql", 'select * from t1;')
 {
    "query" : "select * from t1;",
- "result_set" : [
- [ "", "" ]
- ],
    "sqlstate" : "00000"
 }

@@ -15,8 +12,7 @@
 {
    "query" : "select * from t1;",
    "result_set" : [
- [ "1", "from MySQL protocol" ],
- [ "", "" ]
+ [ "1", "from MySQL protocol" ]
    ],
    "sqlstate" : "00000"
 }

drizzletest: Result content mismatch

« Back to merge proposal