Merge lp:~hingo/drizzle/drizzle-execute-result_set-off-by-one into lp:~drizzle-trunk/drizzle/development
Proposed by
Henrik Ingo
Status: | Merged |
---|---|
Approved by: | Mark Atwood |
Approved revision: | 2458 |
Merged at revision: | 2480 |
Proposed branch: | lp:~hingo/drizzle/drizzle-execute-result_set-off-by-one |
Merge into: | lp:~drizzle-trunk/drizzle/development |
Diff against target: |
85 lines (+16/-3) 1 file modified
drizzled/plugin/client/cached.h (+16/-3) |
To merge this branch: | bzr merge lp:~hingo/drizzle/drizzle-execute-result_set-off-by-one |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Drizzle Merge Team | Pending | ||
Review via email: mp+86791@code.launchpad.net |
Description of the change
Execute API has off by one error, there is always an empty row at the
end of each result set. This fixes it.
Sorry I have no test for this, I don't know who or what code uses this
in the server except for json_server, which has no tests currently.
To post a comment you must log in.
Hi Henrik,
The slave plugin makes extensive use of the Execute API. We should verify that the replication tests still pass with these changes. Running it through param-build should check that.
-Dave