Merge lp:~hikiko/unity/unity.fixed-tests-wwarnings into lp:unity

Proposed by Eleni Maria Stea on 2015-10-27
Status: Merged
Approved by: Marco Trevisan (Treviño) on 2015-11-17
Approved revision: 4030
Merged at revision: 4048
Proposed branch: lp:~hikiko/unity/unity.fixed-tests-wwarnings
Merge into: lp:unity
Diff against target: 20 lines (+2/-2)
1 file modified
tests/gmockvolume.c (+2/-2)
To merge this branch: bzr merge lp:~hikiko/unity/unity.fixed-tests-wwarnings
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) 2015-10-27 Approve on 2015-11-17
PS Jenkins bot (community) continuous-integration Approve on 2015-11-11
Review via email:

Commit message

Replaced deprecated calls in tests to get rid of compiler warnings

Description of the change

Replaced deprecated calls in tests to get rid of compiler warnings

To post a comment you must log in.
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Marco Trevisan (Treviño) (3v1n0) wrote :


review: Approve
Marco Trevisan (Treviño) (3v1n0) wrote :

I'm not sure whether this is related, but it seems it causes a segmentation fault on powerpc builds.

Also looking at this better, the arguments order has to be fixed; while you should use the GTask API everywhere, getting rid of G_ASYNC_RESULT too.

review: Needs Fixing
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Marco Trevisan (Treviño) (3v1n0) wrote :


review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'tests/gmockvolume.c'
--- tests/gmockvolume.c 2013-10-07 13:45:13 +0000
+++ tests/gmockvolume.c 2015-11-11 07:27:39 +0000
@@ -234,7 +234,7 @@
234 g_mock_volume_set_mount(mock_volume, G_MOUNT(g_mock_mount_new()));234 g_mock_volume_set_mount(mock_volume, G_MOUNT(g_mock_mount_new()));
236 callback(G_OBJECT (volume),236 callback(G_OBJECT (volume),
237 G_ASYNC_RESULT (g_simple_async_result_new (G_OBJECT (volume), callback, user_data, NULL)),237 G_TASK (g_task_new (G_OBJECT (volume), NULL, callback, user_data)),
238 user_data);238 user_data);
@@ -254,7 +254,7 @@
254 gpointer user_data)254 gpointer user_data)
256 callback(G_OBJECT (volume),256 callback(G_OBJECT (volume),
257 G_ASYNC_RESULT (g_simple_async_result_new (G_OBJECT (volume), callback, user_data, NULL)),257 G_TASK (g_task_new (G_OBJECT (volume), NULL, callback, user_data)),
258 user_data);258 user_data);