Code review comment for lp:~hikiko/unity/unity.fixed-tests-wwarnings

Marco Trevisan (TreviƱo) (3v1n0) wrote :

I'm not sure whether this is related, but it seems it causes a segmentation fault on powerpc builds.

https://launchpadlibrarian.net/225695938/buildlog_ubuntu-xenial-powerpc.unity_7.4.0%2B16.04.20151110.2-0ubuntu1_BUILDING.txt.gz

Also looking at this better, the arguments order has to be fixed; while you should use the GTask API everywhere, getting rid of G_ASYNC_RESULT too.

review: Needs Fixing

« Back to merge proposal