Merge lp:~hid-iwata/qbzr/curved-diff-handle into lp:qbzr
Proposed by
IWATA Hidetaka
Status: | Merged |
---|---|
Approved by: | Jonathan Riddell |
Approved revision: | 1430 |
Merged at revision: | 1434 |
Proposed branch: | lp:~hid-iwata/qbzr/curved-diff-handle |
Merge into: | lp:qbzr |
Diff against target: |
91 lines (+39/-12) (has conflicts) 2 files modified
NEWS.txt (+5/-0) lib/diffview.py (+34/-12) Text conflict in NEWS.txt |
To merge this branch: | bzr merge lp:~hid-iwata/qbzr/curved-diff-handle |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jonathan Riddell (community) | Approve | ||
Review via email: mp+74833@code.launchpad.net |
Description of the change
Make configurable change marker style of qdiff(side by side view). Straight lines or curved lines.
Sample of curved line style is here.
http://
# This does nothing important, this is just matter of liking.
# Feel free to reject it.
To post a comment you must log in.
I think these curved lines are a nice improvement.
I don't see a need to keep the current straight lines around as an option, it's not something users are likely to care enough about and the curved lines are nicer.
So I'll approve if the config option is not added.
Also all non-private methods should have a doc string to explain what they do (my rule, not qbzr's) so "def create_line" should be documented.