Code review comment for lp:~hid-iwata/qbzr/curved-diff-handle

Jonathan Riddell (jr) wrote :

I think these curved lines are a nice improvement.

I don't see a need to keep the current straight lines around as an option, it's not something users are likely to care enough about and the curved lines are nicer.

So I'll approve if the config option is not added.

Also all non-private methods should have a doc string to explain what they do (my rule, not qbzr's) so "def create_line" should be documented.

review: Needs Fixing

« Back to merge proposal