Code review comment for lp:~henrik-ziegeldorf/hipl/locator-type1-fix
Revision history for this message
| Henrik Ziegeldorf (henrik-ziegeldorf) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
> I noticed one function with one free() was removed. Where's the memory
> deallocated now?
Nowhere. That part was obsolete and has been removed during refactoring. Before, a temporary, intermediate message was used to build the parameter into and copy it from there later. All in all it was pretty useless and misleading.
> You talk about refactoring but did you *test* handovers?
Yes, on my virtual machines.