Code review comment for lp:~henrik-ziegeldorf/hipl/locator-type1-fix

Revision history for this message
Christof Mroz (christof-mroz) wrote :

On 24.11.2011 15:53, Henrik Ziegeldorf wrote:
>> One more minor thing:
>>
>> On 24.11.2011 14:36, Henrik Ziegeldorf wrote:
>>> + int err = 0, i = 0, count = 0,
>> addrs_len;
>>
>> i and count are unsigned, and addrs_len is size_t.
>
> Please include the corresponding hunk of the change, so I'm able to quickly locate the place in the code.

Sorry for that. Here's the hunk i meant:

> === modified file 'modules/update/hipd/update_builder.c'
> --- modules/update/hipd/update_builder.c 2011-08-15 14:11:56 +0000
> +++ modules/update/hipd/update_builder.c 2011-11-24 13:35:59 +0000
> @@ -80,22 +86,25 @@
> + int err = 0, i = 0, count = 0, addrs_len;

« Back to merge proposal