done thanks.
On Mon, Apr 15, 2013 at 10:55 AM, Benjamin Saller < <email address hidden>> wrote:
> LGTM w/trivial > > > https://codereview.appspot.com/8583048/diff/1/juju/agents/base.py > File juju/agents/base.py (right): > > https://codereview.appspot.com/8583048/diff/1/juju/agents/base.py#newcode41 > juju/agents/base.py:41: if e.errno != 17: > Could you use errno.EEXIST here rather than the magic number? > > https://codereview.appspot.com/8583048/ > > -- > https://code.launchpad.net/~hazmat/juju/var-run-mass-restart/+merge/158980 > You are the owner of lp:~hazmat/juju/var-run-mass-restart. >
« Back to merge proposal
done thanks.
On Mon, Apr 15, 2013 at 10:55 AM, Benjamin Saller <
<email address hidden>> wrote:
> LGTM w/trivial /codereview. appspot. com/8583048/ diff/1/ juju/agents/ base.py /codereview. appspot. com/8583048/ diff/1/ juju/agents/ base.py# newcode41 base.py: 41: if e.errno != 17: /codereview. appspot. com/8583048/ /code.launchpad .net/~hazmat/ juju/var- run-mass- restart/ +merge/ 158980
>
>
> https:/
> File juju/agents/base.py (right):
>
> https:/
> juju/agents/
> Could you use errno.EEXIST here rather than the magic number?
>
> https:/
>
> --
> https:/
> You are the owner of lp:~hazmat/juju/var-run-mass-restart.
>