Code review comment for lp:~hazmat/pyjuju/var-run-mass-restart

Revision history for this message
Kapil Thangavelu (hazmat) wrote :

done thanks.

On Mon, Apr 15, 2013 at 10:55 AM, Benjamin Saller <
<email address hidden>> wrote:

> LGTM w/trivial
>
>
> https://codereview.appspot.com/8583048/diff/1/juju/agents/base.py
> File juju/agents/base.py (right):
>
> https://codereview.appspot.com/8583048/diff/1/juju/agents/base.py#newcode41
> juju/agents/base.py:41: if e.errno != 17:
> Could you use errno.EEXIST here rather than the magic number?
>
> https://codereview.appspot.com/8583048/
>
> --
> https://code.launchpad.net/~hazmat/juju/var-run-mass-restart/+merge/158980
> You are the owner of lp:~hazmat/juju/var-run-mass-restart.
>

« Back to merge proposal