lp:~hazmat/pyjuju/var-run-mass-restart
- Get this branch:
- bzr branch lp:~hazmat/pyjuju/var-run-mass-restart
Branch merges
- Juju Engineering: Pending requested
-
Diff: 19 lines (+7/-1)1 file modifiedjuju/agents/base.py (+7/-1)
Branch information
Recent revisions
- 620. By Jeroen T. Vermeulen
-
Makefile improvements and fixes.
Whenever I tried to run "make check" or "make review" in a juju branch, I would get output like:
bzr: ERROR: Not a branch: "/".
bzr: ERROR: Not a branch: "/".
bzr: ERROR: Not a branch: "/".
bzr: ERROR: Not a branch: "/".
make: *** [check] Error 1The errors seem to happen (and I'll admit I don't know how or why) because
there are several lines in the Makefile each defining $(modified) as a shell
command involving bzr. I get the same result on a cloud machine as on my development system.
Giving each of those variables a separate name fixed the errors.There were also other problems: the linters weren't actually being run, there
was no helpful indication of pep8 and/or pyflakes being missing, newly added
files weren't being checked, greps for ".py" suffixes sometimes neglectedto
escape the dot (so it stood for "any character followed by py"). I fixed all of those.Finally there were some cosmetic nuisances. Spacing of the command lines was
irregular, and some use of Perl-style regexes in grep became unnecessary.One of the checks in the "review" target was commented out. I don't know why,
so I left that as-is. - 619. By Thomas Herve
-
Only allow one subordinate relations between svcs
It seems to be that topology.
has_relation_ between_ endpoints didn't check for
subordinates properly. - 618. By Kapil Thangavelu
-
Properly encode maas tags in urls.
Hopefully the last in the sordid history of maas tag support. Revno 616 reverted
attempts to string serialize tags for urls, but which had broken constraint
comparisions. Those string serialization had been attempt in revno 597 and 598
to encode maas tags properly for maas client usage. This branch properly
captures the raw tags string for use by the client, while preserving the
constraint comparisons restored in revno 616. - 617. By Martin Packman
-
Fix os-scheduler-hints constraint to pass correct json layout [r=hazmat,jameinel]
- 616. By Kapil Thangavelu
-
Fix broken maas-tags constraint.
The maas tags wasn't properly converting values for comparision
and was not previously testing tag constraint comparisons. - 615. By Kapil Thangavelu
-
Unit process multiple relations in defined order.
Previously when unit agents were being notified of multiple relations, typicaly
at startup, they would process them in essentially random order. This would
complicate things for applications that would have peer relations as well, for
ha or replication, as they couldn't tell if they were being run standalone or
in a cluster/quorum. Instead when a unit has multiple relations, we process
peer relations first followed by client/server relations.R=bcsaller
CC=
https://codereview. appspot. com/7341044 - 614. By Kapil Thangavelu
-
Increase zk session and ping times.
During scale testing work, one of the take aways was the default zookeeper
session time was too low, which caused issues for any transient communication
problems between the agents the zk. The managed client work landed subsequently
does recovery for this and for session expiration, but its better to avoid
the issue entirely by increasing the session time and increasing the heartbeat
time periodicity.R=bcsaller
CC=
https://codereview. appspot. com/7231079 - 613. By Kapil Thangavelu
-
Drop orchestra provider support
The orchestra provider is dead upstream, and represents
a significant support burden on the code base. Given
hardware deployments are directed towards MaaS and no
current users, its better to drop this now. - 612. By Kapil Thangavelu
-
Fix relation-ids cache coherency for hooks.
Relation-ids was answering questions about relations
directly from state, whilst other pieces of relation-*
cli was using a hook execution cache. This led to
odd races where a hook would query relation-ids
and then attempt to use relation-list/etc against
that relation resulting in a relation not found error.This branch also does a drive by to improve the error
reporting for relation not found to include the relation
id where applicable.R=bcsaller
CC=
https://codereview. appspot. com/7241062
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:pyjuju