Code review comment for lp:~hazmat/juju-gui/yaml-export-bool-fix

Revision history for this message
Kapil Thangavelu (hazmat) wrote :

i'm going to update this branch based on a simpler upstream fix.

building the file is basically $ make browserify in the upstream. I'm
currently using a branch of upstream (original mp attempt failed, simpler
solution in use but upstream wants to noodle on it before inclusion). i
guess i'll toss the doc for it into the hacking doc. re individual lines..
its all automated output so i couldn't really say. given the test failures
i have trying (unrelated) its hard to get validation going, outside of the
manual usage i've been doing.

-k

On Wed, Jul 24, 2013 at 8:49 PM, Gary Poster <email address hidden>wrote:

> Thanks Kapil. Omitting lines 6 and 8 doesn't look right. Could you
> verify?
>
> I'd also like to include instructions on how to duplicate this file--what
> you did to generate this--at least like what we had in line 5
>
> Thanks
>
> Gary
> --
>
> https://code.launchpad.net/~hazmat/juju-gui/yaml-export-bool-fix/+merge/176822
> You are the owner of lp:~hazmat/juju-gui/yaml-export-bool-fix.
>

« Back to merge proposal