lp:~hazmat/juju-gui/yaml-export-bool-fix

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp:juju-gui/experimental

Juju GUI Hackers: Pending requested 2013-07-24

Diff: 15 lines (+4/-5)

1 file modified

app/assets/javascripts/js-yaml.min.js (+4/-5)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1200625: gui export is exporting invalid config options / not respecting type when serializng

High

Fix Released

Link a bug report

Related blueprints

888. By Kapil Thangavelu on 2013-07-24

update js-yaml dep to include 1.1 yaml parser compat for bool aliases

887. By Gary Poster on 2013-07-24

Subordinates should not be deployed with unit ct.

Deploying a subordinate with a unit count causes an error in core. This
prevents one from entering a unit count in the charm panel (did not touch ghost
inspector, that may also need it) and defaults to 0. This also affects
fakebackend.

R=rharding, matthew.scott
CC=
https://codereview.appspot.com/11627044

886. By Richard Harding on 2013-07-24

TRIVIAL: Add raring to the filters.

- There are 6 raring packages undiscoverable currently due to there not being
a filter option to show them
- This adds that string.
- None of these are 'reviewed' so you must uncheck reviewed charms to see
them.
- This will go away when filters do, but was added as a quick favor to
~charmers so the raring ones are 'visible'.

R=
CC=
https://codereview.appspot.com/11507045

885. By Richard Harding on 2013-07-23

Move config.js into the HEAD of the body.

- Defer didn't help. Error still occurred.
- It's clear that the config.js either hadn't finished downloading or parsing.
- It can be run stand alone so moved to the head to get it up the request list
grouping.

R=
CC=
https://codereview.appspot.com/11577044

884. By Richard Harding on 2013-07-23

Force the order of execution of JS using defer.

- Defer allows the scripts to be downloaded async, however it *forces* the
browser to execute them in the order they appear in the DOM.
- There's a chance that we've had users hitting out of order execution between
this code causing Y.juju.App to not be defined during startTheApp. This should
force this to not occur.

- Testing this just isn't possible. We're not 100% sure that it's the issue
and it's darn unrepeatable. The only repeatable case was a stale cache.
However, it has been demonstrated on machines in incognito mode so there is
something there. It's just very hard to reproduce.

R=gary.poster
CC=
https://codereview.appspot.com/11571044

883. By Richard Harding on 2013-07-23

Break out left breakout panel from juju-inspector

- In order for items to be reused as a left-breakout they cannot be under the
.juju-inspector css tree or else it becomes a css nightmare.
- This restructures the default html layout so that the yui3-inspector-panel
is css agnostic and inside of it are the two main components, .juju-inspector
and the left breakout panel.
- The CharmDetails uses the left breakout panel and is situated to show inside
of that.
- Due to these changes some css needed tweaking.
- Anything that wants to reuse the .juju-inspector css rules in the left
breakout panel will have to add that css class to their own template output.

QA:

To QA, run the gui with the serviceInspector flag and deploy a service. Then
click on that service to bring up the inspector and click on the cs:... url to
open the charm details view into the left breakout panel.

R=bac, benji
CC=
https://codereview.appspot.com/11714043

882. By Gary Poster on 2013-07-22

Update service menus and enable for inspector

One of the last big issues remaining in the UX design to make the inspector usable was to make a disoverable way of creating relations. Luca and Ant worked together to revamp the existing popup menu for the purpose. This branch takes their design work and makes it work for both inspector and non-inspector uses. In order to have it work well, I had to update some of the calculations that determined where the menu was drawn.

R=benji, bac
CC=
https://codereview.appspot.com/11620043

881. By Richard Harding on 2013-07-22

Rename second inspector to ViewletManager.

- Prevent having inspector.inspector. The inspector is the controller that
manages events and such.
- The viewletManager is an object that helps control showing/hiding/cleaning
up viewlets in use.
- Update css classes and docs to describe the ViewletManager
- Update tests to use the updated class.
- Move the file to just viewlets as it's the source of managing viewlets and
contains the viewletbase class.
- update the module name and namespace to match the updated terminology.

R=jeff.pihach, benji
CC=
https://codereview.appspot.com/11424045

880. By Richard Harding on 2013-07-22

Update backend urls to manage.jujucharms.com

R=
CC=
https://codereview.appspot.com/11673043

879. By j.c.sackett on 2013-07-22

Aligns Charm id and BrowserCharm id

This branch represents the second painful step in aligning the charm models and
running everything off the up to date charmworld API.
-Charm and BrowserCharm both now have an attr named StoreId; this is the id for
use with the data store (e.g. precise/ceph-12). id is now aligned with the fully
qualified id (e.g. cs:precise/ceph-12) on both models.
-A number of data shims in initializers are introduced to ensure that these
properties are set properly in both models.

R=benjamin.saller, jeff.pihach
CC=
https://codereview.appspot.com/11611043