Code review comment for lp:~hatch/juju-gui/1123291-update-hacking

Land with changes.

I'm asking you for a few more fly-bys from what I noticed of your
adventures. Thanks!

Gary

https://codereview.appspot.com/7322056/diff/1/HACKING
File HACKING (right):

https://codereview.appspot.com/7322056/diff/1/HACKING#newcode14
HACKING:14: Before you get the GUI, first you need to get Juju. For
PyJuju, the original
Add:

...first you need to get Juju. We use the fresh one from the Juju PPA.
For PyJuju...

https://codereview.appspot.com/7322056/diff/1/HACKING#newcode15
HACKING:15: Python-based implementation, we use a custom branch of Juju
that supplies the
add "also":

...implementation, we also use...

https://codereview.appspot.com/7322056/diff/1/HACKING#newcode20
HACKING:20:
Add this here:

sudo add-apt-repository ppa:juju/pkgs

This will also be important for python-shelltoolbox if the dev is
running precise.

https://codereview.appspot.com/7322056/diff/1/HACKING#newcode49
HACKING:49: locally::
also add explanation "python-shelltoolbox and python-selenium for
browser tests, ..."

https://codereview.appspot.com/7322056/diff/1/HACKING#newcode52
HACKING:52: sudo add-apt-repository ppa:gophers/go
On 2013/02/12 21:40:56, bac wrote:
> I wonder if we should actually mention lbox here or perhaps later in a
new
> section about contributing code?

I like the simplicity of putting everything at the top. We explain it
in the text, for people who care.

https://codereview.appspot.com/7322056/diff/1/HACKING#newcode55
HACKING:55: sudo apt-get install nodejs npm imagemagick lbox
python-sphinx python-yaml python-tz python-virtualenv
python-shelltoolbox
add python-selenium please (see docs/browser-testing.rst if you are
curious about the source for these two deps)

https://codereview.appspot.com/7322056/