lp:~hatch/juju-gui/1123291-update-hacking
- Get this branch:
- bzr branch lp:~hatch/juju-gui/1123291-update-hacking
Branch merges
- Juju GUI Hackers: Pending requested
-
Diff: 79 lines (+43/-7)1 file modifiedHACKING (+43/-7)
Related bugs
Bug #1123291: Update HACKING readme with missing details | High | Fix Released |
Related blueprints
Branch information
Recent revisions
- 379. By Madison Scott-Clary
-
Create ghost service while configuring.
When deploying from the charm panel, a ghost service is created in the environment while the user configures the charm. Once the charm is deployed, the service is made 'real'. If the deploy is canceled, the ghost is removed. If the panel is closed by a clickoutside event, the ghost remains, and clicking on it opens the panel back to the configuration pane (this allows panning, zooming, dragging, etc). If the service is dragged, it maintains its position after being deployed.
R=gary.poster, teknico
CC=
https://codereview. appspot. com/7308086 - 378. By Benji York
-
Add a warning about unsupported browsers.
The tests for the code are a bit unusual in that the code under test is
embedded in an HTML file, so it must be extracted and the test file built my
the Makefile so it can be tested. I don't think this approach is too heinous. - 377. By Benji York
-
Add a warning about unsupported browsers.
The tests for the code are a bit unusual in that the code under test is
embedded in an HTML file, so it must be extracted and the test file built my
the Makefile so it can be tested. I don't think this approach is too heinous.R=bac, gary.poster
CC=
https://codereview. appspot. com/7299071 - 376. By Nicola Larosa
-
Surface more code docs.
Sorry for the big branch. A good chunk of it is the regenerated
"undocumented" file.This branch goes over all 20 main source files, and gets most
comment blocks out of there and into the generated pages. It
rearranges the module and class directives so that all the
code parts are reachable from the pages. It also adds some
comment blocks to modules, classes and methods: the
undocumented count is now down to 173.R=gary.poster, bac
CC=
https://codereview. appspot. com/7312067 - 375. By Francesco Banconi
-
Added GUI unit tests in the browser test suite.
Juju GUI unit tests are now included in the CI process.
Also added a test exercising the environment connection.Updated the charm deployment process: "juju set" is no
longer used, and the charm configuration is now provided
by a temporary configuration file.To run browser tests:
sudo apt-get install python-shelltoolbox python-selenium python-yaml juju
bin/test-charm lp:~frankban/juju-gui/bug-1117554-gui-tests-in-browserR=gary.poster, teknico
CC=
https://codereview. appspot. com/7308068 - 374. By Brad Crittenden
-
Cross-browser CSS tweaks
Both firefox and IE rendered the charm panel poorly for different reasons.
This branch adds tweaks of a dubious nature to force them to behave.I am unhappy about the adjustment to padding-left that makes IE render the
charm content in the right vertical spot. Of course by doing so it is now 6px
further to the left than desired but that is much less noticeable. Reviewers
might want to look at the screen shots on the bug.R=gary.poster, hatch, matthew.scott
CC=
https://codereview. appspot. com/7310054 - 373. By Madison Scott-Clary
-
No outside resources for CI tests
This is, for the most part, Gary's branch. It tested out well on EC2 along with the recent fix that was causing wait_on_service to blow up.
R=gary.poster, bac
CC=
https://codereview. appspot. com/7307065 - 372. By Nicola Larosa
-
Better charm panel docs.
Improve the charm panel comment blocks.
R=gary.poster, matthew.scott
CC=
https://codereview. appspot. com/7307063
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:juju-gui/experimental