Code review comment for lp:~haggai-eran/unity-2d/rtl

Revision history for this message
Alberto Mardegan (mardy) wrote :

> Alberto,
> I tried testing your branch, but I had to merge it with 4.0 in order for it to
> compile on an updated oneiric system. In order for it to work I also had to
> add the QT_LAYOUT_DIRECTION to the po file. Should I do it manually, without
> updating the pot file and the rest of the po files?

When making the next release we'll update the pot file, and the translators will have to translate the QT_LAYOUT_DIRECTION text as appropriate.
For testing purposes yes, you'll have to update it manually.

For the other issues, looks like you did a great job in fixing them! Thanks!
I think you need to file two different merge requests to get your changes accepted in unity and nux, first.

« Back to merge proposal