Code review comment for lp:~gz/qbzr/reliable_exception_encoding_686735
Revision history for this message
| Martin Packman (gz) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> OK, that's enough for now. I'd like to see this explanation added as
> comment in bare except block.
Done.
> > If KeyboardInterrupt should be being reraised, I should probably add that to
> the try/except around commands.run_bzr too, while Python 2.3 is still
> supported.
> >
> > Is this change based on the right revision, or should I move it to be daggy
> if you want to land it as a bug fix?
>
> I'm going to cherrypick it to backport the fix to lp:qbzr/0.20.
I've moved the change back in to r1267 as well which looks like it's merge cleanly to any branches to want it on, and fiddled with a couple of other details. If there is anything else you'd like me to do, say. What's the qbzr NEWS policy? It might be easier for you to add it when merging if this is going to multiple places.