lp:~gz/qbzr/reliable_exception_encoding_686735

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:qbzr at revision 1363

Alexander Belchenko: Approve on 2011-04-21

Diff: 155 lines (+91/-12)

2 files modified

lib/subprocess.py (+46/-12)
lib/tests/test_subprocess.py (+45/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #686735: qbzr crashed with UnicodeDecodeError in run_subprocess_command()

Critical

Fix Released

Link a bug report

Related blueprints

1272. By Martin Packman on 2011-04-20

Change of approach, just serialise needed attributes rather than introspecting exception instances

1271. By Martin Packman on 2011-04-20

As qbzr uses splitlines and bencode doesn't escape newlines do need unicode-escape

1270. By Martin Packman on 2011-04-16

Add extra test for existing logic over which exception attributes should be serialised

1269. By Martin Packman on 2011-04-16

Add comment suggested by Alexander in review, and make original try/except Python 2.4 friendly too

1268. By Martin Packman on 2011-04-16

Bencode exception instances with dedicated function for better reliability

1267. By Alexander Belchenko on 2010-05-24

encode strings in error objects with unicode-escape.

1266. By Alexander Belchenko on 2010-05-23

qupdate, qunbind, qgetupdates: new --immediate option will run these commands without waiting for the user to click on the Ok button (Luis Arias)

1265. By Gary van der Merwe on 2010-05-20

qannotate: Fix recursion stop for translate_positions.

1264. By Gary van der Merwe on 2010-05-20

qannotate: Try maintain the scroll position and selection when switching annotated revisions.

1263. By Gary van der Merwe on 2010-05-20

qannotate: Don't move the log_list selection when changing the annotated revision.