Merge lp:~gz/juju-core/1.14_disable_testmanagestateserveapi_1219661 into lp:juju-core/1.14
Proposed by
Martin Packman
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Martin Packman | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 1749 | ||||
Proposed branch: | lp:~gz/juju-core/1.14_disable_testmanagestateserveapi_1219661 | ||||
Merge into: | lp:juju-core/1.14 | ||||
Diff against target: |
16 lines (+5/-0) 1 file modified
cmd/jujud/machine_test.go (+5/-0) |
||||
To merge this branch: | bzr merge lp:~gz/juju-core/1.14_disable_testmanagestateserveapi_1219661 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Juju Engineering | Pending | ||
Review via email: mp+186573@code.launchpad.net |
Commit message
cmd/jujud: Skip flaky TestManageState
Backport test skip from 1.15 development series, as test
unreliability is getting in the way of bot landing other
backports on the 1.14 branch.
https:/
R=rogpeppe
Description of the change
cmd/jujud: Skip flaky TestManageState
Backport test skip from 1.15 development series, as test
unreliability is getting in the way of bot landing other
backports on the 1.14 branch.
To post a comment you must log in.
Reviewers: mp+186573_ code.launchpad. net,
Message:
Please take a look.
Description: ServesAPI
cmd/jujud: Skip flaky TestManageState
Backport test skip from 1.15 development series, as test
unreliability is getting in the way of bot landing other
backports on the 1.14 branch.
https:/ /code.launchpad .net/~gz/ juju-core/ 1.14_disable_ testmanagestate serveapi_ 1219661/ +merge/ 186573
(do not edit description out of merge proposal)
Please review this at https:/ /codereview. appspot. com/13722051/
Affected files (+7, -0 lines): machine_ test.go
A [revision details]
M cmd/jujud/
Index: [revision details] 20130918181705- 8tzwn5sauj3n28o 1
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: tarmac-
+New revision: <email address hidden>
Index: cmd/jujud/ machine_ test.go machine_ test.go' machine_ test.go 2013-09-13 07:49:37 +0000 machine_ test.go 2013-09-19 15:35:17 +0000
=== modified file 'cmd/jujud/
--- cmd/jujud/
+++ cmd/jujud/
@@ -374,7 +374,12 @@
}
}
+// TODO(jam): 2013-09-02 http:// pad.lv/ 1219661 ServesAPI( c *gc.C) { pad.lv/ 1219661") ithState( c, state.JobManage State, func(conf agent.Config, fastDialOpts)
+// This test has been failing regularly on the Bot. Until someone fixes it
so
+// it doesn't crash, it isn't worth having as we can't tell when someone
+// actually breaks something.
func (s *MachineSuite) TestManageState
+ c.Skip("does not pass reliably on the bot (http://
s.assertJobW
agentState *state.State) {
st, _, err := conf.OpenAPI(
c.Assert(err, gc.IsNil)