Merge lp:~gz/juju-core/1.14_disable_testmanagestateserveapi_1219661 into lp:juju-core/1.14

[Martin Packman]

cmd/jujud: Skip flaky TestManageStateServesAPI

Backport test skip from 1.15 development series, as test
unreliability is getting in the way of bot landing other
backports on the 1.14 branch.

https://codereview.appspot.com/13722051/

R=rogpeppe

cmd/jujud: Skip flaky TestManageStateServesAPI

Backport test skip from 1.15 development series, as test
unreliability is getting in the way of bot landing other
backports on the 1.14 branch.

https://codereview.appspot.com/13722051/

[Martin Packman (gz)]

Reviewers: mp+186573_code.launchpad.net,

Message:
Please take a look.

Description:
cmd/jujud: Skip flaky TestManageStateServesAPI

Backport test skip from 1.15 development series, as test
unreliability is getting in the way of bot landing other
backports on the 1.14 branch.

https://code.launchpad.net/~gz/juju-core/1.14_disable_testmanagestateserveapi_1219661/+merge/186573

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/13722051/

Affected files (+7, -0 lines):
   A [revision details]
   M cmd/jujud/machine_test.go

Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: tarmac-20130918181705-8tzwn5sauj3n28o1
+New revision: <email address hidden>

Index: cmd/jujud/machine_test.go
=== modified file 'cmd/jujud/machine_test.go'
--- cmd/jujud/machine_test.go 2013-09-13 07:49:37 +0000
+++ cmd/jujud/machine_test.go 2013-09-19 15:35:17 +0000
@@ -374,7 +374,12 @@
   }
  }

+// TODO(jam): 2013-09-02 http://pad.lv/1219661
+// This test has been failing regularly on the Bot. Until someone fixes it
so
+// it doesn't crash, it isn't worth having as we can't tell when someone
+// actually breaks something.
  func (s *MachineSuite) TestManageStateServesAPI(c *gc.C) {
+ c.Skip("does not pass reliably on the bot (http://pad.lv/1219661")
   s.assertJobWithState(c, state.JobManageState, func(conf agent.Config,
agentState *state.State) {
    st, _, err := conf.OpenAPI(fastDialOpts)
    c.Assert(err, gc.IsNil)

[Roger Peppe (rogpeppe)]

On 2013/09/19 15:43:58, gz wrote:
> Please take a look.

LGTM

https://codereview.appspot.com/13722051/

=== modified file 'cmd/jujud/machine_test.go'
--- cmd/jujud/machine_test.go	2013-09-13 07:49:37 +0000
+++ cmd/jujud/machine_test.go	2013-09-19 15:43:19 +0000
@@ -374,7 +374,12 @@
 	}
 }
 
+// TODO(jam): 2013-09-02 http://pad.lv/1219661
+// This test has been failing regularly on the Bot. Until someone fixes it so
+// it doesn't crash, it isn't worth having as we can't tell when someone
+// actually breaks something.
 func (s *MachineSuite) TestManageStateServesAPI(c *gc.C) {
+	c.Skip("does not pass reliably on the bot (http://pad.lv/1219661")
 	s.assertJobWithState(c, state.JobManageState, func(conf agent.Config, agentState *state.State) {
 		st, _, err := conf.OpenAPI(fastDialOpts)
 		c.Assert(err, gc.IsNil)