Code review comment for lp:~gz/juju-ci-tools/gzip_logs_hang

Revision history for this message
Aaron Bentley (abentley) wrote :

Sorry, I didn't mean actually execcing gzip, just asserting that subprocess does/doesn't get run (like the tests previously did) is fine. I was saying that mocking out glob isn't necessary to control whether gzip gets run, and it's a better test if we don't.

« Back to merge proposal