Merge lp:~gz/juju-ci-tools/gzip_logs_hang into lp:juju-ci-tools

[Martin Packman]

Avoid hang I ran into testing upgrade locally where having no logs in the artefacts dir hung the process

If there are no logs, don't try to gzip them, rather than running gzip with no args - which makes it read from stdin instead.

[Aaron Bentley (abentley)]

The code looks fine, but I think the tests should create log files if necessary. We want to assert that gzip -f gets run. And we want a test case for dump_logs, asserting that it doesn't run gzip if there are no logs. Yes, there are no tests for deploy_stack, but I think that needs to change. I've been adding tests for other testless functionality when I change it.

review: Needs Fixing

[lp:~gz/juju-ci-tools/gzip_logs_hang]

752. By Aaron Bentley on 2014-12-01

Give equal time to old and new clients in DeployManyAttempt

753. By Aaron Bentley on 2014-12-01

Use eight containers instead of 10 for AWS.

754. By Aaron Bentley on 2014-12-02

Improve logging for industrial test.

755. By Martin Packman on 2014-12-02

More concise reporting in jujupy when waiting for status changes

[Martin Packman (gz)]

I disagree about actually wanting to exec gzip in tests - I think that's exactly the level we want to mock out. Asserting that the gzip command line and the filename passed, which I did as a side effect as part of this change, should be good enough to trust we'll really get the compressed files in real usage.

[Aaron Bentley (abentley)]

Sorry, I didn't mean actually execcing gzip, just asserting that subprocess does/doesn't get run (like the tests previously did) is fine. I was saying that mocking out glob isn't necessary to control whether gzip gets run, and it's a better test if we don't.

[lp:~gz/juju-ci-tools/gzip_logs_hang]

756. By Aaron Bentley on 2014-12-02

Emit status text for agent timeout.

757. By Aaron Bentley on 2014-12-02

Suite param istead of --quick option, rename 'quick' to 'density'.

758. By Curtis Hovey on 2014-12-03

Support both .tgz and .tar.gz backup file names.

759. By Aaron Bentley on 2014-12-04

Support Joyent for backup/restore.

760. By Curtis Hovey on 2014-12-04

Add support for weekly streams. Downloading candidated and extracting them.

761. By Curtis Hovey on 2014-12-04

Fixed revision_build key.

762. By Curtis Hovey on 2014-12-04

Remove pdb. :(.

763. By Curtis Hovey on 2014-12-04

Fixed revision_build in test data.

764. By Aaron Bentley on 2014-12-04

Add schedule_reliability_tests.py

765. By Aaron Bentley on 2014-12-04

Skip artifacts directories.

766. By Curtis Hovey on 2014-12-04

Add a sleep to ha because Juju lies about ha ready.

767. By Aaron Bentley on 2014-12-08

Use a 2x2 config for DeployManyAttempt when type is maas.

768. By Aaron Bentley on 2014-12-08

Add run-reliability-test

769. By Aaron Bentley on 2014-12-08

Add timeout to EnvJujuClient.destroy_environment.

770. By Martin Packman on 2014-12-10

Add newline after final report while waiting for changes in jujupy

771. By Aaron Bentley on 2014-12-10

Select suite and jobs for reliability testing.

772. By John George on 2014-12-11

Move the parse_error function and its mock dependency to test_utility.py

773. By Aaron Bentley on 2014-12-11

Increase set of agent-state-infos that indicate failure.

774. By Aaron Bentley on 2014-12-11

Update dependency handling.

775. By John George on 2014-12-11

Add support to the terminate_instances function for maas.

776. By Curtis Hovey on 2014-12-12

Use jujuci.py helper to get artifacts.

777. By Aaron Bentley on 2014-12-15

Support agent-url

778. By Aaron Bentley on 2014-12-15

Use find_candidates in schedule-hetero-control

779. By Aaron Bentley on 2014-12-15

Always delete jenv in industrial test.

780. By Curtis Hovey on 2014-12-15

Revert use of jujuci.py because it will not exist on the remote machine.

781. By Curtis Hovey on 2014-12-16

Do not let EC2 issues damn unit-test results.

782. By Curtis Hovey on 2014-12-16

Added build_juju.py to mange building juju on a jenkin's job.

783. By Curtis Hovey on 2014-12-16

Fix argument order in build_juju.py.

784. By Curtis Hovey on 2014-12-16

Alway honour --juju-release-tools.

785. By Curtis Hovey on 2014-12-16

Give maas more time to upgrade.

786. By Curtis Hovey on 2014-12-16

Fix args to build_juju.py; osx-client is what crossbuild expects.

787. By Curtis Hovey on 2014-12-16

Do not swallow errors retrieving logs.

788. By Curtis Hovey on 2014-12-16

Extend the status timeout during upgrades to 5 minutes.

789. By Curtis Hovey on 2014-12-16

Use relativePath when creating links to archived files.

790. By Curtis Hovey on 2014-12-16

Added --install-juju to test-win-client so that we can switch to the crossbuilder.

791. By John George on 2014-12-17

add branch 1.21 support to check_blockers

792. By Curtis Hovey on 2015-01-06

Parameterise args so that restricted network testing can run on precise or trusty.

793. By Aaron Bentley on 2015-01-06

Log exceptions in the context where they were emitted.

794. By Curtis Hovey on 2015-01-07

Use dump_env_logs to call dump_logs for each machine in the env.

795. By Curtis Hovey on 2015-01-07

Allway update juju when updating the master and the slaves.

796. By Curtis Hovey on 2015-01-09

Increase the size of tmpfs to 3G.

797. By Curtis Hovey on 2015-01-13

Always capture logs from all the machines that were deployed.

798. By John George on 2015-01-14

Adds support for running juju quickstart to the jujupy module and adds the quickstart_deploy.py script for starting test jobs.

799. By Curtis Hovey on 2015-01-14

Need more output to debug build failures.

800. By John George on 2015-01-15

Add install of juju-quickstart and juju-deployer. Also pull latest updates into ~/repository.

801. By John George on 2015-01-15

Change repository update order, so CWD is ~/juju-ci-tools, so that make install-deps can proceed.

802. By John George on 2015-01-16

Added the --service-count option to quickstart_deploy.py

803. By Curtis Hovey on 2015-01-16

Move common bash rules into python jobs so that anyone can run the script locally.

804. By Aaron Bentley on 2015-01-19

Handle missing environments more cleanly.

805. By John George on 2015-01-20

Set management-certificate-path for Azuze quickstart tests.

806. By Curtis Hovey on 2015-01-21

Build vivid packages for testing.

807. By Aaron Bentley on 2015-01-22

Add remove-machine to industrial testing.

808. By Aaron Bentley on 2015-01-23

Avoid creating temp juju homes inside temp juju homes.

809. By Curtis Hovey on 2015-01-28

Add support to run unit-tests on windows,

810. By Curtis Hovey on 2015-01-28

Remove errant raise of exception.

811. By Curtis Hovey on 2015-01-28

Added rules to explain the version under test.

812. By Curtis Hovey on 2015-01-28

pass the glob to the script, not bash.

813. By Curtis Hovey on 2015-01-28

Fixed editing typo in JUJU_HOME.

814. By Curtis Hovey on 2015-01-28

Make the script more verbose for jenkins.

815. By Curtis Hovey on 2015-01-30

Do not sync agents from s3 because juju-ci is the canonical source. it is already correct.

816. By Aaron Bentley on 2015-01-30

Support testing backups on Azure.

817. By Aaron Bentley on 2015-01-30

Run bootstrap and restore asynchronously.

818. By Curtis Hovey on 2015-01-31

OSX cannot be crosscompiled (else x509 errors). Test osx client.

819. By Curtis Hovey on 2015-01-31

Ensure the osx testing env is destroyed.

820. By Curtis Hovey on 2015-01-31

Updated the osx-slave when we update branches.

821. By Curtis Hovey on 2015-01-31

It is not an error to destroy an non-existent env.

822. By Curtis Hovey on 2015-01-31

Pass the -y flag to destroy env.

823. By John George on 2015-02-02

While publishing weekly streams, backup the buildvars.json files to S3, to maintain a record of the builds that have been published.

824. By Aaron Bentley on 2015-02-03

Add --debug to all tests.

825. By Curtis Hovey on 2015-02-04

Update slaves by their registered hostname.

826. By John George on 2015-02-06

Make common-startup.sh less verbose.

827. By Curtis Hovey on 2015-02-06

Use new Joyent Client API.

828. By Curtis Hovey on 2015-02-06

Fix type and DNS resolution to update master and slaves.

829. By John George on 2015-02-06

While running _deploy_stack print Juju status between bootstrap and stack deployment, before upgrade and just before destroying the environment.

830. By Curtis Hovey on 2015-02-06

Just use host to get ip address of juju-ci.

831. By Curtis Hovey on 2015-02-09

Use juju-ci's real address when updating slaves. Update path for osx-slave.

832. By Curtis Hovey on 2015-02-10

Retry ssh connections to win-slave.

833. By Aaron Bentley on 2015-02-10

Switch OpenStackAccount to manager_from_config.

834. By Aaron Bentley on 2015-02-10

Use manager_from_config with AWS and OpenStack.

835. By John George on 2015-02-11

Restore debug output after common-startup.sh sources ec2rc

836. By Aaron Bentley on 2015-02-11

Allow optional temp_env_name to control the environment name used.

837. By Curtis Hovey on 2015-02-13

Added --clean-env to setup_workspace, removed teardown from common-startup.

838. By Curtis Hovey on 2015-02-13

Clean the osx client job too.

839. By Curtis Hovey on 2015-02-13

Fix mock calls.

840. By Curtis Hovey on 2015-02-13

Move the call to euca-create-tags to when we know the instances have descriptions.

841. By Curtis Hovey on 2015-02-14

Update clean_resources.py to use AWSAccount.manager_from_config.

842. By Curtis Hovey on 2015-02-17

Do not call euca when credentials are not set.

843. By Aaron Bentley on 2015-02-17

Implement upgrade testing.

844. By Curtis Hovey on 2015-02-17

Use google's DNS to resolve the hosts to update.

845. By Curtis Hovey on 2015-02-17

Added azure lib and reconciled call to joyent client in preperation for modules to move.

846. By Curtis Hovey on 2015-02-17

Removed recursive tree and added symlink to match juju-release-tools.

847. By Curtis Hovey on 2015-02-17

Remove symlink because it breaks discover unittests.

848. By Curtis Hovey on 2015-02-17

Leave no mongod running.

849. By Aaron Bentley on 2015-02-18

Use credentials to access Jenkins.

850. By Aaron Bentley on 2015-02-18

Add credentials to build_juju and candidates.

851. By Curtis Hovey on 2015-02-18

Use jenkins user in osx build and run. Always use authentication when calling jujuci.

852. By Curtis Hovey on 2015-02-18

Source the creds in the bash script because they are not exposed by deploy_stack.

853. By Curtis Hovey on 2015-02-19

OS X uses a different JUJU_HOME.

854. By Curtis Hovey on 2015-02-19

Set a JUJU_HOME for os x.

855. By Curtis Hovey on 2015-02-19

Source the os x bashrc which maps linuxisms to os x.

856. By Curtis Hovey on 2015-02-19

Strip the \n from the basic auth because it causes request errors seen on several slaves.

857. By Curtis Hovey on 2015-02-19

Always source the os x bashrc.

858. By Curtis Hovey on 2015-02-19

JUJU_HOME != cloud-city on os-x

859. By Curtis Hovey on 2015-02-19

Make authorized jujuci requests from publish-revision and vagrant tests.

860. By Curtis Hovey on 2015-02-19

~/ci was removed from osx. we use $HOME now like other slaves.

861. By Aaron Bentley on 2015-02-19

Fix restricted-network tests to use auth for accessing Jenkins artifacts.

862. By Curtis Hovey on 2015-02-19

Ensure win tests don't see OpenSSH, and do see powershell.

863. By Curtis Hovey on 2015-02-20

Sanitise the os.environ['PATH'] for windows, not the sys.path.

864. By Curtis Hovey on 2015-02-20

Improve verbosity.

865. By Aaron Bentley on 2015-02-20

Remove unused LOCAL_JENKINS_URL

866. By Curtis Hovey on 2015-02-20

Copy the environ PATH to Path for win32; always remove OpenSSH.

867. By Aaron Bentley on 2015-02-20

Enhance upgrade test.

868. By Curtis Hovey on 2015-02-20

Cleanup manual instance when describe fails.

869. By Aaron Bentley on 2015-02-23

Run multiple suites and combine results.

870. By Aaron Bentley on 2015-02-23

Add --old-stable parameter to run-reliability-test.

871. By Curtis Hovey on 2015-02-24

Run win unittests through powershell.

872. By Aaron Bentley on 2015-02-24

Use authenticated access for schedule_... scripts.

873. By Aaron Bentley on 2015-02-24

schedule_reliability_tests accepts multiple --suite options.

874. By Aaron Bentley on 2015-02-24

Fix schedule_hetero_control executability.

875. By Seman on 2015-02-25

Ensure tests use future distro-info-data

876. By John George on 2015-02-25

Resolve MaaS DNS names against the server defined in the environment and use the IP to fetch logs.

877. By Curtis Hovey on 2015-02-26

Reverted revno 876 because AttributeError: 'EnvJujuClient' object has no attribute 'client'

878. By Aaron Bentley on 2015-02-27

Add upgrade-charm to industrial testing.

879. By Curtis Hovey on 2015-03-02

Moved azure and joyent instance management into juju-ci.tools.

880. By Aaron Bentley on 2015-03-02

Delete all files in before running industrial-test.

881. By Curtis Hovey on 2015-03-03

Honour old_age when killing joyent procs.

882. By John George on 2015-03-04

Add juju-deployer test support.

883. By John George on 2015-03-04

Reverting do to un-wanted arg order change.

884. By John George on 2015-03-04

Add juju-deployer test support.

885. By Curtis Hovey on 2015-03-05

Rety tagging instances instead of failing.

886. By Seman on 2015-03-05

Added a test to verify 'juju run' command continues to work before and after an upgrade

887. By Aaron Bentley on 2015-03-09

Switch deploy_stack from Environment to EnvJujuClient.

888. By Aaron Bentley on 2015-03-09

Revert r887.

889. By Aaron Bentley on 2015-03-09

Switch deploy_stack from Environment to EnvJujuClient.

890. By Aaron Bentley on 2015-03-11

Destroy environment when status is broken.

891. By Martin Packman on 2015-03-11

Always print a newline after GroupReporter output

892. By Martin Packman on 2015-03-12

Added script to fetch the latest Amazon image id, fixing merge history

893. By Seman on 2015-03-12

Updated a call to assess_juju_run() to ensure every deployment has a working ssh and run. Renamed test_upgrade() to assess_upgrade()

894. By Aaron Bentley on 2015-03-13

Add get-juju-bin and get-certification-bin subcommands to jujuci

895. By Aaron Bentley on 2015-03-13

Provide stub get_distro_information if lsb_release cannot be imported.

896. By Curtis Hovey on 2015-03-13

Provide more network information for analysis.

897. By Curtis Hovey on 2015-03-13

Fix function defintion.

898. By Martin Packman on 2015-03-13

Revert addition of get_ami script from r892

899. By Aaron Bentley on 2015-03-13

Add run_deploy_job.bash

900. By Aaron Bentley on 2015-03-13

Handle series in run-deploy-job.bash

901. By Curtis Hovey on 2015-03-13

Restore the default route when the test fails.

902. By Seman on 2015-03-13

Added safe_print_status to output juju status without raising exceptions. Updated deploy_stack to use this function in finally blocks so that it doesn't prevent destroy_environment from running.

903. By Curtis Hovey on 2015-03-17

Do not build i386 packages when BUILD_i386 is not "true".

904. By Curtis Hovey on 2015-03-17

Fix syntax error.

905. By Curtis Hovey on 2015-03-17

Simple build and test script for merge gating go projects using git.

906. By Curtis Hovey on 2015-03-17

Allow passing of all the filters get_ami uses, and change defaults fo virt and root_store.

907. By Aaron Bentley on 2015-03-18

Pass extra args to deploy_job.

908. By John George on 2015-03-18

Added the add_basic_testing_arguments function for setting up arguments needed for quickstart, deployer and charmstore tests.

909. By Seman on 2015-03-20

Updated deploy_stack() to retain jenv file after a failure.

910. By Martin Packman on 2015-03-24

Improvements to the git_gate script in log output and arg handling

911. By John George on 2015-03-25

Re-write quickstart_deploy.py to use EnvJujuClient.

912. By Curtis Hovey on 2015-03-27

Added vivid-slave-b.vapour.ws to the update script.

913. By Curtis Hovey on 2015-03-27

Added a script to run unit-tests for ecosystem projects that import juju.

914. By Martin Packman on 2015-03-30

Fix broken tests for git gate script

915. By John George on 2015-03-30

Add a test script to deploy from the charm store stagging server.

916. By John George on 2015-04-03

Re-raise exceptions encountered while running quickstart_deploy steps and ensure the script exits with non-zero on errors.

917. By Curtis Hovey on 2015-04-06

Fix calls to service.service_name attribute.

918. By Curtis Hovey on 2015-04-06

Added script to delete old s3 control-buckets.

919. By Curtis Hovey on 2015-04-06

Remove redundant workspace setup and hardcoded token.

920. By Martin Packman on 2015-04-08

Add lxc container logs to collected artifacts

921. By Martin Packman on 2015-04-08

Add region as a parameter to get_ami script

922. By Curtis Hovey on 2015-04-08

Use the local goroot if it is present.

923. By Martin Packman on 2015-04-14

Add wrapping at 79 character width to GroupReporter

924. By Martin Packman on 2015-04-16

Set TMP during unit tests on windows to mitigate cleanup issues

925. By Martin Packman on 2015-04-16

Update gotestwin.bash to not depend on lastSuccessfulBuild

926. By Curtis Hovey on 2015-04-17

Spec the mocks with the azure classes.

927. By Aaron Bentley on 2015-04-17

Add --keep-env flag to deploy_job.

928. By Aaron Bentley on 2015-04-17

Add --upload-tools to deploy_job.py

929. By Martin Packman on 2015-04-21

Further improvements to robustness of running unit tests on windows

930. By Martin Packman on 2015-04-22

More poking on the gotesttarball.py script

931. By Martin Packman on 2015-04-23

Correct wrapping of dots on groups displayed after the first

932. By Aaron Bentley on 2015-04-23

Auto-enable support for cloudsigma in 1.24.

933. By Martin Packman on 2015-04-23

Retest relations work after upgrade in deploy_stack

934. By Curtis Hovey on 2015-04-24

Bidirectional testing of ecosystem projects.

935. By Curtis Hovey on 2015-04-24

Use the command name, not an aliases (fixes broken job).

936. By Curtis Hovey on 2015-04-24

Copy stats after copying buildvars.

937. By Seman on 2015-04-27

Added code to upload the test results of Heterogeneous Control to S3.

938. By Aaron Bentley on 2015-04-27

Remove DeployManyFactory.

939. By Aaron Bentley on 2015-04-27

Fix bug #1449123 by passing juju_home.

940. By Curtis Hovey on 2015-04-27

Open critical "blocker" bugs prevent merges.

941. By Curtis Hovey on 2015-04-29

Close blocking bugs for a branch/series that passed in CI.

942. By Martin Packman on 2015-05-01

Prevent joyent failures from mixing kvm images with non-kvm packages

943. By Martin Packman on 2015-05-01

Make check_blockers.py nicer for human use

944. By Martin Packman on 2015-05-05

Tweak how jujupy wait reporting finalises

945. By Curtis Hovey on 2015-05-05

Capture logs from deployer tests.

946. By Curtis Hovey on 2015-05-05

Add support for --agent-stream to deploy_job.py.

947. By Curtis Hovey on 2015-05-05

Ensure the os gest package updates to find the current package.

948. By Curtis Hovey on 2015-05-05

Use the ubuntu archives in the test.

949. By Curtis Hovey on 2015-05-06

Soft-code $PACKAGES_JOB for certification.

950. By Curtis Hovey on 2015-05-06

Ubuntu changed the naming convention again :(.

951. By Curtis Hovey on 2015-05-07

Certify any Ubuntu version.

952. By Martin Packman on 2015-05-11

Correct deploy job juju run logging

953. By Curtis Hovey on 2015-05-11

Remove extra ")" causing a syntax error and make test failure.

954. By Curtis Hovey on 2015-05-15

Set default juju to 1.20.11 whenthe juju under test in 1.21.x or 1.22.x.

955. By John George on 2015-05-15

Support taking a bundle name in addition to the bundle config file path.

956. By Curtis Hovey on 2015-05-15

Also ABRT mongod runing from /usr/lib/juju/bin/.

957. By Curtis Hovey on 2015-05-18

Added get-build-vars command to jujuci.py.

958. By Curtis Hovey on 2015-05-19

Use get-build-vars instead of sourcing buildvard.bash.

959. By Curtis Hovey on 2015-05-19

Added manage-build-revision.bash extracted from revision-result job.

960. By Curtis Hovey on 2015-05-20

Use lowercase name for $revision_build.

961. By Aaron Bentley on 2015-05-25

Treat cloudsigma as provisional in juju 2.5

962. By Curtis Hovey on 2015-05-26

Add support to build centos7.

963. By Martin Packman on 2015-05-26

Add --race flag to run-unit-test script

964. By Curtis Hovey on 2015-05-27

Include centos and win agents in test streams.

965. By Curtis Hovey on 2015-05-27

Fixed comment.

966. By John George on 2015-05-28

Add run_chaos_monkey.py

967. By Curtis Hovey on 2015-05-29

Remove common-startup.sh.

968. By John George on 2015-06-01

Add sub-command support to jujupy, as well as including subordinate items from Status.agent_items().

969. By Curtis Hovey on 2015-06-01

Set JUJU in the env when testing quickstart,

970. By Curtis Hovey on 2015-06-01

Print the boot staus before starting deployer.

971. By Curtis Hovey on 2015-06-02

client.wait_for_started() before running deployer.

972. By Curtis Hovey on 2015-06-02

Added script to manage the lxc cache for hosts on closed networks.

973. By Curtis Hovey on 2015-06-02

Get juju binaries from build-binary-* jobs.

974. By John George on 2015-06-03

Add wait_for_subordinate_units to jujupy.py.

975. By Martin Packman on 2015-06-03

Use more specific name for per-machine artifacts directories

976. By Aaron Bentley on 2015-06-03

Implement tests for log rotation, using action do and action fetch.

977. By Curtis Hovey on 2015-06-04

Use jujuci to get build and job data because it works on all OSes and series.

978. By Curtis Hovey on 2015-06-04

Adjust test env so tht make test can pass on the osx-slave.

979. By John George on 2015-06-05

Add start action calls to run_chaos_monkey.

980. By John George on 2015-06-08

Adds the is_healthy() function to run_chaos_monkey.py for executing the health check script provided by the user.

981. By Curtis Hovey on 2015-06-10

Hush lint and make tests work on other series and OSes.

982. By Martin Packman on 2015-06-11

Destroy lxc containers before attempting to create them in run-unit-tests script

983. By Curtis Hovey on 2015-06-11

Move substrate (not juju) functions to substrate.py.

984. By Martin Packman on 2015-06-12

New Remote class for communicating with juju machines

985. By Martin Packman on 2015-06-12

Fix test broken by misadventures in lint

986. By Aaron Bentley on 2015-06-15

Fix error handling in assess_log_rotation.

987. By John George on 2015-06-15

Run chaos, wait for completion and check health.

988. By Curtis Hovey on 2015-06-15

Added MAASAccount to work directly with the MAAS substrate.

989. By Curtis Hovey on 2015-06-15

Update get_machines_for_log to get real maas ip addresses.

990. By Curtis Hovey on 2015-06-15

Fix dump_env_logs calls passing obsolete keyword.

991. By Curtis Hovey on 2015-06-16

Always collect logs.

992. By John George on 2015-06-17

Modify run_chaos_monkey.py to use the first action ID, for a unit, as the monkey-id for all subsequent action calls.

993. By John George on 2015-06-18

Prevent subsequent unleash_once calls from overwriting the stored ID for a unit.

994. By John George on 2015-06-18

Give deploy_stack extra time to complete on MAAS.

995. By Curtis Hovey on 2015-06-22

Ensure name is defined in the juju config for maas.

996. By Seman on 2015-06-23

Upload last completed compatibility test result.

997. By Curtis Hovey on 2015-06-23

Fix test-win-client exit code, script path, and deps.

998. By Curtis Hovey on 2015-06-24

Add support for Wily.

999. By Seman on 2015-06-24

Ensure Jenkins build is completed before uploading the compatibility test result by a build number.

1000. By Aaron Bentley on 2015-06-25

Use verbose output for run-juju-eco-unit-tests.

1001. By Aaron Bentley on 2015-06-25

Use workspace-runner for test-win-client.

1002. By John George on 2015-06-26

Add a script to run basic openstack commands as a sniff test.

1003. By Martin Packman on 2015-06-26

Use trusty state server when testing windows charms

1004. By Curtis Hovey on 2015-07-01

Add --robust to select an ideal test combination.

1005. By Martin Packman on 2015-07-01

Add pipdep tool for managing requirements using an S3 cache

1006. By Martin Packman on 2015-07-01

Add python-pip to make install-deps

1007. By Martin Packman on 2015-07-01

Support precise pip by using file: url for directory

1008. By Martin Packman on 2015-07-01

Add winrm remote class to enable interacting with windows machines

1009. By Martin Packman on 2015-07-02

Enable windows deployment testing and log collection

1010. By Curtis Hovey on 2015-07-02

Remove callto kill long running joyent procs.

1011. By Curtis Hovey on 2015-07-02

Retry wekkly stream publication.

1012. By Martin Packman on 2015-07-03

Update gzip hang fix for trunk, and address review comment by abentley

[Martin Packman (gz)]

Fixed Aaron's concern with the tests, so will just land.

[lp:~gz/juju-ci-tools/gzip_logs_hang]

1013. By Martin Packman on 2015-07-03

Fix lint

=== modified file 'deploy_stack.py'
--- deploy_stack.py	2015-07-02 00:59:47 +0000
+++ deploy_stack.py	2015-07-03 18:46:32 +0000
@@ -35,7 +35,6 @@
 from substrate import (
     destroy_job_instances,
     LIBVIRT_DOMAIN_RUNNING,
-    MAASAccount,
     resolve_remote_dns_names,
     run_instances,
     start_libvirt_domain,
@@ -216,12 +215,12 @@
             copy_local_logs(env, directory)
         else:
             copy_remote_logs(remote, directory)
-        subprocess.check_call(
-            ['gzip', '-f'] +
-            glob.glob(os.path.join(directory, '*.log')))
     except Exception as e:
         print_now("Failed to retrieve logs")
         print_now(str(e))
+    log_files = glob.glob(os.path.join(directory, '*.log'))
+    if log_files:
+        subprocess.check_call(['gzip', '-f'] + log_files)
 
 
 lxc_template_glob = '/var/lib/juju/containers/juju-*-lxc-template/*.log'

=== modified file 'test_assess_heterogeneous_control.py'
--- test_assess_heterogeneous_control.py	2015-06-22 00:14:18 +0000
+++ test_assess_heterogeneous_control.py	2015-07-03 18:46:32 +0000
@@ -16,31 +16,41 @@
     SimpleEnvironment,
     _temp_env,
     )
+from utility import (
+    temp_dir,
+)
 
 
 class TestDumping_env(TestCase):
 
     def test_dumping_env_exception(self):
         client = EnvJujuClient(SimpleEnvironment('env'), '5', '4')
-        with patch.object(client, 'destroy_environment') as de_mock:
-            with patch('subprocess.check_call') as cc_mock:
-                with patch('deploy_stack.copy_remote_logs') as crl_mock:
-                    with self.assertRaises(ValueError):
-                        with dumping_env(client, 'foo', 'bar'):
-                            raise ValueError
-        crl_mock.assert_called_once_with('foo', 'bar')
-        cc_mock.assert_called_once_with(['gzip', '-f'])
+        with temp_dir() as log_dir:
+            with patch.object(client, 'destroy_environment') as de_mock:
+                with patch('subprocess.check_call', autospec=True) as cc_mock:
+                    with patch('deploy_stack.copy_remote_logs') as crl_mock:
+                        with self.assertRaises(ValueError):
+                            with dumping_env(client, 'a-hostname', log_dir):
+                                raise ValueError
+            crl_mock.assert_called_once_with('a-hostname', log_dir)
+        self.assertEquals(cc_mock.call_count, 0)
         de_mock.assert_called_once_with()
 
     def test_dumping_env_success(self):
+        def _fake_remote_logs(remote, directory):
+            with open(os.path.join(directory, 'fake.log'), 'w') as f:
+                f.write('log contents')
         client = EnvJujuClient(SimpleEnvironment('env'), '5', '4')
-        with patch.object(client, 'destroy_environment') as de_mock:
-            with patch('subprocess.check_call') as cc_mock:
-                with patch('deploy_stack.copy_remote_logs') as crl_mock:
-                    with dumping_env(client, 'foo', 'bar'):
-                        pass
-        crl_mock.assert_called_once_with('foo', 'bar')
-        cc_mock.assert_called_once_with(['gzip', '-f'])
+        with temp_dir() as log_dir:
+            with patch.object(client, 'destroy_environment') as de_mock:
+                with patch('subprocess.check_call', autospec=True) as cc_mock:
+                    with patch('deploy_stack.copy_remote_logs', autospec=True,
+                               side_effect=_fake_remote_logs) as crl_mock:
+                        with dumping_env(client, 'a-hostname', log_dir):
+                            pass
+            crl_mock.assert_called_once_with('a-hostname', log_dir)
+            log_path = os.path.join(log_dir, 'fake.log')
+            cc_mock.assert_called_once_with(['gzip', '-f', log_path])
         self.assertEqual(de_mock.call_count, 0)