Code review comment for lp:~gz/juju-ci-tools/gzip_logs_hang

Revision history for this message
Martin Packman (gz) wrote :

I disagree about actually wanting to exec gzip in tests - I think that's exactly the level we want to mock out. Asserting that the gzip command line and the filename passed, which I did as a side effect as part of this change, should be good enough to trust we'll really get the compressed files in real usage.

« Back to merge proposal