Merge lp:~gunnarhj/ubuntu-themes/orange-links-back-please into lp:ubuntu-themes

Proposed by Gunnar Hjalmarsson
Status: Needs review
Proposed branch: lp:~gunnarhj/ubuntu-themes/orange-links-back-please
Merge into: lp:ubuntu-themes
Diff against target: 40 lines (+9/-2)
3 files modified
Ambiance/gtk-3.20/gtk-main.css (+1/-1)
Radiance/gtk-3.20/gtk-main.css (+1/-1)
debian/changelog (+7/-0)
To merge this branch: bzr merge lp:~gunnarhj/ubuntu-themes/orange-links-back-please
Reviewer Review Type Date Requested Status
Adolfo Jayme Barrientos (community) Disapprove
Ubuntu Artwork Packagers Pending
Review via email: mp+341929@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Adolfo Jayme Barrientos (fitojb) wrote :

The old color caused me headaches and most likely failed catastrophically at the WCAG guidelines for contrast.

review: Disapprove

Unmerged revisions

609. By Gunnar Hjalmarsson

{Ambiance,Radiance}/gtk-3.20/gtk-main.css: Change back to orange links (LP: #1749103)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Ambiance/gtk-3.20/gtk-main.css'
--- Ambiance/gtk-3.20/gtk-main.css 2018-03-22 07:12:28 +0000
+++ Ambiance/gtk-3.20/gtk-main.css 2018-03-22 18:56:19 +0000
@@ -89,7 +89,7 @@
89@define-color question_bg_color rgb (138, 173, 212);89@define-color question_bg_color rgb (138, 173, 212);
90@define-color error_fg_color rgb (235, 235, 235);90@define-color error_fg_color rgb (235, 235, 235);
91@define-color error_bg_color rgb (223, 56, 44);91@define-color error_bg_color rgb (223, 56, 44);
92@define-color link_color #007aa6;92@define-color link_color @selected_bg_color;
9393
94/* theme common colors */94/* theme common colors */
95@define-color button_text_shadow alpha(white, 0.4);95@define-color button_text_shadow alpha(white, 0.4);
9696
=== modified file 'Radiance/gtk-3.20/gtk-main.css'
--- Radiance/gtk-3.20/gtk-main.css 2018-03-22 07:18:04 +0000
+++ Radiance/gtk-3.20/gtk-main.css 2018-03-22 18:56:19 +0000
@@ -88,7 +88,7 @@
88@define-color question_bg_color rgb (138, 173, 212);88@define-color question_bg_color rgb (138, 173, 212);
89@define-color error_fg_color rgb (235, 235, 235);89@define-color error_fg_color rgb (235, 235, 235);
90@define-color error_bg_color rgb (223, 56, 44);90@define-color error_bg_color rgb (223, 56, 44);
91@define-color link_color #007aa6;91@define-color link_color @selected_bg_color;
9292
93/* theme common colors */93/* theme common colors */
94@define-color button_bg_color shade (@bg_color, 1.02); /*shade (#cdcdcd, 1.08);*/94@define-color button_bg_color shade (@bg_color, 1.02); /*shade (#cdcdcd, 1.08);*/
9595
=== modified file 'debian/changelog'
--- debian/changelog 2018-03-22 08:28:09 +0000
+++ debian/changelog 2018-03-22 18:56:19 +0000
@@ -1,3 +1,10 @@
1ubuntu-themes (16.10+18.04.20180322.4-0ubuntu1) UNRELEASED; urgency=medium
2
3 * {Ambiance,Radiance}/gtk-3.20/gtk-main.css:
4 - Change back to orange links (LP: #1749103).
5
6 -- Gunnar Hjalmarsson <gunnarhj@ubuntu.com> Thu, 22 Mar 2018 19:49:00 +0100
7
1ubuntu-themes (16.10+18.04.20180322.3-0ubuntu1) bionic; urgency=medium8ubuntu-themes (16.10+18.04.20180322.3-0ubuntu1) bionic; urgency=medium
29
3 [ Daniel van Vugt ]10 [ Daniel van Vugt ]

Subscribers

People subscribed via source and target branches