Merge lp:~gunnarhj/ubuntu-themes/orange-links-back-please into lp:ubuntu-themes

Proposed by Gunnar Hjalmarsson on 2018-03-22
Status: Needs review
Proposed branch: lp:~gunnarhj/ubuntu-themes/orange-links-back-please
Merge into: lp:ubuntu-themes
Diff against target: 40 lines (+9/-2)
3 files modified
Ambiance/gtk-3.20/gtk-main.css (+1/-1)
Radiance/gtk-3.20/gtk-main.css (+1/-1)
debian/changelog (+7/-0)
To merge this branch: bzr merge lp:~gunnarhj/ubuntu-themes/orange-links-back-please
Reviewer Review Type Date Requested Status
Adolfo Jayme (community) Disapprove on 2018-03-31
Ubuntu Artwork Packagers 2018-03-22 Pending
Review via email: mp+341929@code.launchpad.net
To post a comment you must log in.
Adolfo Jayme (fitojb) wrote :

The old color caused me headaches and most likely failed catastrophically at the WCAG guidelines for contrast.

review: Disapprove

Unmerged revisions

609. By Gunnar Hjalmarsson on 2018-03-22

{Ambiance,Radiance}/gtk-3.20/gtk-main.css: Change back to orange links (LP: #1749103)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Ambiance/gtk-3.20/gtk-main.css'
2--- Ambiance/gtk-3.20/gtk-main.css 2018-03-22 07:12:28 +0000
3+++ Ambiance/gtk-3.20/gtk-main.css 2018-03-22 18:56:19 +0000
4@@ -89,7 +89,7 @@
5 @define-color question_bg_color rgb (138, 173, 212);
6 @define-color error_fg_color rgb (235, 235, 235);
7 @define-color error_bg_color rgb (223, 56, 44);
8-@define-color link_color #007aa6;
9+@define-color link_color @selected_bg_color;
10
11 /* theme common colors */
12 @define-color button_text_shadow alpha(white, 0.4);
13
14=== modified file 'Radiance/gtk-3.20/gtk-main.css'
15--- Radiance/gtk-3.20/gtk-main.css 2018-03-22 07:18:04 +0000
16+++ Radiance/gtk-3.20/gtk-main.css 2018-03-22 18:56:19 +0000
17@@ -88,7 +88,7 @@
18 @define-color question_bg_color rgb (138, 173, 212);
19 @define-color error_fg_color rgb (235, 235, 235);
20 @define-color error_bg_color rgb (223, 56, 44);
21-@define-color link_color #007aa6;
22+@define-color link_color @selected_bg_color;
23
24 /* theme common colors */
25 @define-color button_bg_color shade (@bg_color, 1.02); /*shade (#cdcdcd, 1.08);*/
26
27=== modified file 'debian/changelog'
28--- debian/changelog 2018-03-22 08:28:09 +0000
29+++ debian/changelog 2018-03-22 18:56:19 +0000
30@@ -1,3 +1,10 @@
31+ubuntu-themes (16.10+18.04.20180322.4-0ubuntu1) UNRELEASED; urgency=medium
32+
33+ * {Ambiance,Radiance}/gtk-3.20/gtk-main.css:
34+ - Change back to orange links (LP: #1749103).
35+
36+ -- Gunnar Hjalmarsson <gunnarhj@ubuntu.com> Thu, 22 Mar 2018 19:49:00 +0100
37+
38 ubuntu-themes (16.10+18.04.20180322.3-0ubuntu1) bionic; urgency=medium
39
40 [ Daniel van Vugt ]

Subscribers

People subscribed via source and target branches