Merge lp:~grupocitec/ocb-addons/report_webkit_custom_paper_size into lp:ocb-addons

[GrupoCITEC]

New option for defininf custom paper size in report_webkit headers

[Holger Brunn (Therp) (hbrunn)]

Can't this be done in a feature module? OCB is meant to provide bug fixes, not new features.

review: Needs Information

[Holger Brunn (Therp) (hbrunn)]

any input from the webkit people?

[bruno bottacini (bruno-bottacini)]

i made a module using the GrupoCITEC patch:

lp:~bruno-bottacini/+junk/7.0-report_webkit_custom_paper_size

[Holger Brunn (Therp) (hbrunn)]

Bruno,

I can't access your branch, did you change anything here?

But if we can do the same thing with a module I'd rather not add a new feature in ocb, so I'll disapprove.

review: Disapprove

[GrupoCITEC (grupocitec)]

That was my branch, not Bruno's.

That was my first try to collaborate on OCB branch after all the motivational things about the quick feedback I listened on last year's OpenDays in Brussels. But I was waiting for months for a review of it with no response so I deleted it. Sorry.

I added just 4 or 6 lines of code to WebKit report module in order to enable the options to set custom paper size.

If someone is still interested I can get the code and do a MP again.

"Holger Brunn (Therp)" <email address hidden> wrote:
>Review: Disapprove
>
>Bruno,
>
>I can't access your branch, did you change anything here?
>
>But if we can do the same thing with a module I'd rather not add a new
>feature in ocb, so I'll disapprove.
>--
>https://code.launchpad.net/~grupocitec/ocb-addons/report_webkit_custom_paper_size/+merge/195418
>You are the owner of
>lp:~grupocitec/ocb-addons/report_webkit_custom_paper_size.

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

[Lionel Sausin - Initiatives/Numérigraphe (ls-initiatives)]

FYI I'm trying to push this feature into v8 on github - https://github.com/odoo/odoo/pull/1084

Unmerged revisions

9660. By <email address hidden> on 2013-11-15

report_webkit: Add custom paper size option

=== modified file 'report_webkit/__openerp__.py'
--- report_webkit/__openerp__.py	2013-08-15 07:54:23 +0000
+++ report_webkit/__openerp__.py	2013-11-15 16:21:03 +0000
@@ -48,7 +48,7 @@
     - Raw HTML debugger
     - Book printing capabilities
     - Margins definition
-    - Paper size definition
+    - Paper size definition (event custom paper size)
 
 Multiple headers and logos can be defined per company. CSS style, header and
 footer body are defined per company.
 
=== modified file 'report_webkit/header.py'
--- report_webkit/header.py	2012-10-23 16:05:04 +0000
+++ report_webkit/header.py	2013-11-15 16:21:03 +0000
@@ -81,11 +81,14 @@
                 ('Legal', 'Legal    3   8.5 x 14 inches, 215.9 x 355.6 mm'),
                 ('Letter','Letter 2 8.5 x 11 inches, 215.9 x 279.4 mm'),
                 ('Tabloid', 'Tabloid 29 279.4 x 431.8 mm'),
+                ('custom', 'Custom Paper Size'),
                 ],
                 'Paper size',
                 required=True,
                 help="Select Proper Paper size"
-        )
+        ),
+        'paper_width': fields.integer('Paper Width (mm)'),
+        'paper_height': fields.integer('Paper Height (mm)'),
     }
 HeaderHTML()
 
 
=== modified file 'report_webkit/header_view.xml'
--- report_webkit/header_view.xml	2012-10-23 16:05:04 +0000
+++ report_webkit/header_view.xml	2013-11-15 16:21:03 +0000
@@ -26,6 +26,8 @@
                             <field name='company_id'/>
                             <field name="orientation"/>
                             <field name="format"/>
+                            <field name="paper_width" attrs="{'invisible': [('format', '!=', 'custom')], 'required': [('format', '=', 'custom')]}" />
+                            <field name="paper_height" attrs="{'invisible': [('format', '!=', 'custom')], 'required': [('format', '=', 'custom')]}" />
                         </group><group>
                             <field name="margin_top"/>
                             <field name="margin_bottom"/>
 
=== modified file 'report_webkit/webkit_report.py'
--- report_webkit/webkit_report.py	2012-10-23 16:05:04 +0000
+++ report_webkit/webkit_report.py	2013-11-15 16:21:03 +0000
@@ -149,7 +149,11 @@
         if webkit_header.orientation :
             command.extend(['--orientation', str(webkit_header.orientation).replace(',', '.')])
         if webkit_header.format :
-            command.extend(['--page-size', str(webkit_header.format).replace(',', '.')])
+            if webkit_header.format=='custom':
+                command.extend(['--page-width', str(webkit_header.paper_width).replace(',', '.')])
+                command.extend(['--page-height', str(webkit_header.paper_height).replace(',', '.')])
+            else:
+                command.extend(['--page-size', str(webkit_header.format).replace(',', '.')])
         count = 0
         for html in html_list :
             html_file = file(os.path.join(tmp_dir, str(time.time()) + str(count) +'.body.html'), 'w')