Code review comment for lp:~grupocitec/ocb-addons/report_webkit_custom_paper_size

Revision history for this message
GrupoCITEC (grupocitec) wrote :

That was my branch, not Bruno's.

That was my first try to collaborate on OCB branch after all the motivational things about the quick feedback I listened on last year's OpenDays in Brussels. But I was waiting for months for a review of it with no response so I deleted it. Sorry.

I added just 4 or 6 lines of code to WebKit report module in order to enable the options to set custom paper size.

If someone is still interested I can get the code and do a MP again.

"Holger Brunn (Therp)" <email address hidden> wrote:
>Review: Disapprove
>
>Bruno,
>
>I can't access your branch, did you change anything here?
>
>But if we can do the same thing with a module I'd rather not add a new
>feature in ocb, so I'll disapprove.
>--
>https://code.launchpad.net/~grupocitec/ocb-addons/report_webkit_custom_paper_size/+merge/195418
>You are the owner of
>lp:~grupocitec/ocb-addons/report_webkit_custom_paper_size.

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

« Back to merge proposal