gnome-shell:wip/smcv/issue6877

Last commit made on 2023-08-04
Get this branch:
git clone -b wip/smcv/issue6877 https://git.launchpad.net/gnome-shell

Branch merges

Branch information

Name:
wip/smcv/issue6877
Repository:
lp:gnome-shell

Recent commits

a0f8774... by Simon McVittie

Get uninstalled libraries from environment in preference to ELF headers

Introspecting the dynamic headers is low-level and full of implementation
details.

It seems that gnome-shell was assuming the address of the string table is
given by taking the DT_STRTAB dynamic symbol table's value (d_un.d_val)
and casting it to an absolute pointer. However, in some environments
(apparently including Debian mips64el) the DT_STRTAB dynamic symbol
table's d_un.d_val can be merely an offset relative to the base address
of the executable in memory. The base address would have to be parsed from
a different ELF header, which as far as I know is not part of _DYNAMIC.

Rather than trying to look up the Shell executable's base address using
dlinfo() or similar, during unit testing it seems easier to pass in the
uninstalled library search path in the environment, along with other
uninstalled paths that we are going to need anyway.

The reason given for not using GI_TYPELIB_PATH in commit 9bc89b82
"main: Prepend RPATH or RUNPATH paths to gir search paths" was that
g_irepository_prepend_library_path() takes precedence, but we can easily
define our own environment variable that takes even higher precedence.
If it's set, we might as well also bypass the PKGLIBDIR, since while
running uninstalled we *only* want to use the uninstalled libraries.

When not running unit tests, it's desirable to make
`./build/src/gnome-shell` something you can run directly, so continue
to parse the ELF headers - but only on x86_64, where we're reasonably
confident that it works and any regressions with a newer glibc will
be noticed promptly.

Resolves: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/6877
Bug-Debian: https://bugs.debian.org/1042980
Signed-off-by: Simon McVittie <email address hidden>

3c175bc... by Hugo Carvalho

Update Portuguese translation

fe3df0d... by Artur So <email address hidden>

Update Russian translation

2640ccc... by Boyuan Yang

Update Chinese (China) translation

67ab8e8... by Boyuan Yang

Update Chinese (China) translation

56a4d2d... by Sam Hewitt

style: Fix colored indicators lacking style in the overview

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2823>

b625942... by Sam Hewitt

style: Remove important override on button insensitive style

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2823>

d9ed67b... by Sam Hewitt

style: Fix mismatched border radius on notifications

- fixes #6801

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2823>

965e7bf... by Sam Hewitt

style: Fix border on quick settings button

- fixes #6832

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2823>

fd41742... by Sam Hewitt

style: Change lg border radius so it doesn't look cut off in Overview

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2823>