Code review comment for lp:~gesha/linaro-license-protection/non-standart-http-port

Revision history for this message
Georgy Redkozubov (gesha) wrote :

> Just to clarify, this is a pre-requisite for https://code.launchpad.net/~gesha
> /linaro-license-protection/clickthrough-testing/+merge/88387?
>
> Also, it would be nice to add some comments about what do the new rewriterules
> do on lines 8-14 (i.e. "We set environment variable CO_DOMAIN to just the
> domain without the port to use for setting a cookie.").
>
> Otherwise, looks good.

Yes, just to separate the activity :)

> Also, you can make that entire block 'simpler' by using slightly more complex
> RE:
>
>
> RewriteCond %{HTTP_HOST} ^([^\:]*)(\:.*)$
> RewriteRule .* - [E=CO_DOMAIN:%1]

Unfortunately it won't work for port 80

« Back to merge proposal