Merge lp:~gesha/linaro-license-protection/non-standart-http-port into lp:~linaro-automation/linaro-license-protection/trunk

[Georgy Redkozubov]

Added handling of non-standart http port in .htaccess
Mostly needed for testing, but who knows...

[Данило Шеган (danilo)]

Just to clarify, this is a pre-requisite for https://code.launchpad.net/~gesha/linaro-license-protection/clickthrough-testing/+merge/88387?

Also, it would be nice to add some comments about what do the new rewriterules do on lines 8-14 (i.e. "We set environment variable CO_DOMAIN to just the domain without the port to use for setting a cookie.").

Otherwise, looks good.

review: Approve

[Данило Шеган (danilo)]

Also, you can make that entire block 'simpler' by using slightly more complex RE:

 RewriteCond %{HTTP_HOST} ^([^\:]*)(\:.*)$
 RewriteRule .* - [E=CO_DOMAIN:%1]

[Georgy Redkozubov (gesha)]

> Just to clarify, this is a pre-requisite for https://code.launchpad.net/~gesha
> /linaro-license-protection/clickthrough-testing/+merge/88387?
>
> Also, it would be nice to add some comments about what do the new rewriterules
> do on lines 8-14 (i.e. "We set environment variable CO_DOMAIN to just the
> domain without the port to use for setting a cookie.").
>
> Otherwise, looks good.

Yes, just to separate the activity :)

> Also, you can make that entire block 'simpler' by using slightly more complex
> RE:
>
>
> RewriteCond %{HTTP_HOST} ^([^\:]*)(\:.*)$
> RewriteRule .* - [E=CO_DOMAIN:%1]

Unfortunately it won't work for port 80

[lp:~gesha/linaro-license-protection/non-standart-http-port]

37. By Georgy Redkozubov on 2012-01-13

Added comments about new RewriteRule

[Данило Шеган (danilo)]

Uhm, I forgot ? after the second group:

         RewriteCond %{HTTP_HOST} ^([^\:]*)(\:.*)?$
         RewriteRule .* - [E=CO_DOMAIN:%1]

This should work for port 80 as well.

[Georgy Redkozubov (gesha)]

> Uhm, I forgot ? after the second group:
>
>
> RewriteCond %{HTTP_HOST} ^([^\:]*)(\:.*)?$
> RewriteRule .* - [E=CO_DOMAIN:%1]
>
> This should work for port 80 as well.

No, because in general HTTP_HOST can be IP address, host name or FQDN and it won't work for second case ;)

[Данило Шеган (danilo)]

Can you give me an example where it won't work? I just wonder what is it that I am missing?

[Georgy Redkozubov (gesha)]

Use host name as 'host', i.e.:
   host = 'http://localhost'
but it will work with:
   host = 'http://localhost.localdomain' and host = 'http://127.0.0.1'

=== modified file '.htaccess'
--- .htaccess	2011-12-19 16:57:20 +0000
+++ .htaccess	2012-01-13 12:13:26 +0000
@@ -3,6 +3,16 @@
 
 RewriteEngine On
 
+## CO_DOMAIN is set to host name or host address
+## without port number for use in cookie domain
+RewriteCond %{SERVER_PORT} !^80$
+RewriteCond %{HTTP_HOST} (.*)(\:.*)
+RewriteRule .* - [E=CO_DOMAIN:%1]
+
+RewriteCond %{SERVER_PORT} ^80$
+RewriteCond %{HTTP_HOST} (^.*$)
+RewriteRule .* - [E=CO_DOMAIN:%1]
+
 ## Let internal hosts through always.
 # android-build.linaro.org.
 RewriteCond %{REMOTE_ADDR} 50.17.250.69 [OR]
@@ -45,11 +55,11 @@
 # Samsung.
 RewriteCond %{REQUEST_URI} licenses/samsung-accepted.html$
 RewriteCond %{HTTP_COOKIE} downloadrequested=([^\;]*\/)([^/\;]*)
-RewriteRule .* %1%2 [CO=samsunglicenseaccepted-v1:true:.%{HTTP_HOST}:5:%1,R,L]
+RewriteRule .* %1%2 [CO=samsunglicenseaccepted-v1:true:.%{ENV:CO_DOMAIN}:5:%1,R,L]
 # ST-E.
 RewriteCond %{REQUEST_URI} licenses/ste-accepted.html$
 RewriteCond %{HTTP_COOKIE} downloadrequested=([^\;]*\/)([^/\;]*)
-RewriteRule .* %1%2 [CO=stelicenseaccepted-v1:true:.%{HTTP_HOST}:60:%1,R,L]
+RewriteRule .* %1%2 [CO=stelicenseaccepted-v1:true:.%{ENV:CO_DOMAIN}:60:%1,R,L]
 
 ## When license is being declined, show the notice that you have to accept it.
 # Samsung.
@@ -69,7 +79,7 @@
 ## Redirect to the license file protected builds.
 # Samsung.
 RewriteCond %{REQUEST_URI} ^/.*origen.*$
-RewriteRule .* /licenses/samsung-v2.html [CO=downloadrequested:%{REQUEST_URI}:.%{HTTP_HOST},R,L]
+RewriteRule .* /licenses/samsung-v2.html [CO=downloadrequested:%{REQUEST_URI}:.%{ENV:CO_DOMAIN},R,L]
 # ST-E.
 RewriteCond %{REQUEST_URI} ^/.*snowball.*
-RewriteRule .* /licenses/ste.html [CO=downloadrequested:%{REQUEST_URI}:.%{HTTP_HOST},R,L]
+RewriteRule .* /licenses/ste.html [CO=downloadrequested:%{REQUEST_URI}:.%{ENV:CO_DOMAIN},R,L]