linaro-license-protection

Code review comment for lp:~gesha/linaro-license-protection/non-standart-http-port

  1. non-standart-http-port
  2. Merge into trunk
Revision history for this message
Данило Шеган (danilo) wrote :

Just to clarify, this is a pre-requisite for https://code.launchpad.net/~gesha/linaro-license-protection/clickthrough-testing/+merge/88387?

Also, it would be nice to add some comments about what do the new rewriterules do on lines 8-14 (i.e. "We set environment variable CO_DOMAIN to just the domain without the port to use for setting a cookie.").

Otherwise, looks good.

review: Approve

« Back to merge proposal