Merge lp:~gero-bare/scratch/fix-bug-1633916 into lp:~elementary-apps/scratch/scratch
Proposed by
Gero.Bare
Status: | Rejected |
---|---|
Rejected by: | Adam Bieńkowski |
Proposed branch: | lp:~gero-bare/scratch/fix-bug-1633916 |
Merge into: | lp:~elementary-apps/scratch/scratch |
Diff against target: |
116 lines (+67/-2) 2 files modified
plugins/filemanager/FileManagerPlugin.vala (+33/-2) plugins/filemanager/FileView.vala (+34/-0) |
To merge this branch: | bzr merge lp:~gero-bare/scratch/fix-bug-1633916 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Zisu Andrei (community) | Needs Fixing | ||
Review via email:
|
Description of the change
This might be an overkill but I'm not aware of a better solution.
On doc closes check if the document is currently selected and de select it from the file view.
I keep track of the documents in order to disconnect the signals when opportune.
To post a comment you must log in.
Unmerged revisions
- 1775. By Gero.Bare
-
Don't reopen documents unnecessarily.
- 1774. By Gero.Bare
-
Fix a little screw up. It should compile now.
- 1773. By Gero.Bare
-
Now theflemanger selects atomatically the document currently opened in the editor.
Fixed some style issues. - 1772. By Gero.Bare
-
Fix formatting error.
- 1771. By Gero.Bare
-
On document close, check if the file is currently selected and deselect it.
I confirm your branch fixes the issue and does not introduce any regressions.
However, there's a tiny comment inline.