Code review comment for lp:~gero-bare/scratch/fix-bug-1633916

Revision history for this message
Zisu Andrei (matzipan) wrote :

Hey Gero,

Great progress, but I found a little bug.

How to test:
Open a file (say file a)
Then click the settings icon in the top right and click "Add View".
Now press ctrl+o and open a different file (say file b)
Then press ctrl+o and open the same file as the one you opened in your first step (say file a).

You will have two views, one with two tabs, a and b, and one with a single tab, a.

In the view with two tabs. Close "a". This will leave you with a view with "a", and one with "b".

Press the "a" tab. Your selection won't happen.

Also, there's some comments inline.

Let's get this merged!

review: Needs Fixing

« Back to merge proposal