Code review comment for lp:~gero-bare/midori/webkit2download-bug-1173744

Revision history for this message
gue5t gue5t (gue5t) wrote :

Cool, we do need downloads working right with wk2. :)

That said, there are numerous whitespace/style issues in the patch: added and removed blank lines, use of tab characters in files which are indented with spaces, inconsistent presence of spaces around '=', and a couple merge conflicts in the source.

The phrasing of the Aria2 error message could be clarified, and it might also do to add a comment why we are comparing against 200. Are we showing an error dialog if the website returns a non-200 status code to Aria2 (this would be poor form), or is communication between Midori and Aria2 using HTTP (please forgive my ignorance on this point)?

review: Needs Fixing

« Back to merge proposal