Code review comment for lp:~georg-zotti/stellarium/gz_shaderloader-message

Revision history for this message
Fabien Chéreau (xalioth) wrote :

I don't really like this patch:
 - it adds GUI dependencies to deep engine code which should be strictly avoided
 - adding some pop ups in case of failure doesn't add value compared to a normal crash
 - I don't think it's even good you can ask the user whether he wants to continue in this case, he just cannot know. We have to decide for him if an error is critical or not. If it's critical we crash, if not we continue.
 - we should find a more elegant, generic and robust way to deal with crashes or opengl failure, for example by displaying logs in a window just before quitting in case of crash

review: Disapprove

« Back to merge proposal