Code review comment for lp:~gdgellatly/server-env-tools/base-synchro-7.0
Revision history for this message
| Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote | # |
review:
Needs Fixing
(code review, no tests)
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
If people are willing to maintain this, then I'm not opposed to merging in server-env-tools.
2 points, though, to gain my approval:
* the various size constraints seem overzealous to me (esp. server URL and domain which are obviously too short for no good reason)
* there are no automated tests, and for functionality such as this one, this is definitely needed.