Code review comment for lp:~gdgellatly/server-env-tools/base-synchro-7.0
Revision history for this message
| Graeme Gellatly (gdgellatly) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
Oops, meant to mention the insertion of the cr.commit() after each object is synced within the main synchronise method of the wizard. I don't really know any other way of doing it. The RPCProxy commits on each record. Provided one record commits correctly it is highly unlikely future records for an object will not, as the object model matches on both, so as a middle ground I put a database commit on the base_server after each object. If it isn't there and a sync fails on an object/model for any reason, then all prior synced object/model will duplicate because the mapping between record ids fails to write to the db.
Happy to take advice on a better way of doing this, SAVEPOINT just didn't seem to do what I wanted but I could of got it wrong.
Graeme