Code review comment for lp:~gcollura/ubuntu-calculator-app/swipe-copy-button-improvements

Revision history for this message
Riccardo Padovani (rpadovani) wrote :

> Nice work!
>
> I like copy feature, and animation are really pretty.
>
> I have one remark regarding copy feature: It is possible to select many
> calculations to copy, but I could copy only one.
> Why we added confirm button to copy?
> I think "copy" is not so dangerous as "delete". We could just swipe to add to
> clipboard (without confirmation)
> Maybe it will be better to instanly copy whole selected calculation?

This is how the swype from right to left is supposed to work, because you can have plus than one option on the right. So the first swipe is to evidence all options, and the second one to select the option

Thanks for your branch Giulio, I approve it, but address Bartosz comment, he will topapprove this when he think is ready :-)

review: Approve

« Back to merge proposal