Merge lp:~gcollura/ubuntu-calculator-app/swipe-copy-button-improvements into lp:ubuntu-calculator-app

[Giulio Collura]

Add swipe to copy feature on single calculation. Add pressed button effect and fix button height on landscape mode.

Various improvements. I've decided to put all of them in the same MP to save time :)
What I've done:
* Added swipe to copy on single calculation as Riccardo requested
* Added a small effect when a button gets pressed
* (REMOVED) Fix button height in landscape mode (see http://i.imgur.com/XyE1Ide.png)
Tell me what you think and if you see anything wrong.
Thank you!

Giulio

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:75
http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/287/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid/808
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/808/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calculator-app-vivid-amd64-ci/9

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/287/rebuild

review: Approve (continuous-integration)

[Alan Pope 🍺🐧🐱 🦄 (popey)]

On krillin it doesn't *quite* fit on screen.

http://popey.mooo.com/screenshots/device-2015-01-22-222330.png

I'm not sure if we should have the date fully off screen or on. My gut reaction is that the calculation and keys are the most important things, and you can pull down for the date. But I think this needs design input.

[lp:~gcollura/ubuntu-calculator-app/swipe-copy-button-improvements]

76. By Giulio Collura on 2015-01-22

make buttonRatio proportional to scrollableView ratio

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:76
http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/289/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid/810
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/810/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calculator-app-vivid-amd64-ci/11

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/289/rebuild

review: Approve (continuous-integration)

[Bartosz Kosiorek (gang65)]

Nice work!

I like copy feature, and animation are really pretty.

I have one remark regarding copy feature: It is possible to select many calculations to copy, but I could copy only one.
Why we added confirm button to copy?
I think "copy" is not so dangerous as "delete". We could just swipe to add to clipboard (without confirmation)
Maybe it will be better to instanly copy whole selected calculation?

review: Needs Information

[Bartosz Kosiorek (gang65)]

I tested dynamic changing ratio of the buttons, and it is confusing for me.
I think we should keep fix ratio buttons, and find some different solution.

What do you think about adding one more column for horizontal mode?

Could you please split copy and keypad fix to two MR?

review: Needs Information

[Riccardo Padovani (rpadovani)]

> Nice work!
>
> I like copy feature, and animation are really pretty.
>
> I have one remark regarding copy feature: It is possible to select many
> calculations to copy, but I could copy only one.
> Why we added confirm button to copy?
> I think "copy" is not so dangerous as "delete". We could just swipe to add to
> clipboard (without confirmation)
> Maybe it will be better to instanly copy whole selected calculation?

This is how the swype from right to left is supposed to work, because you can have plus than one option on the right. So the first swipe is to evidence all options, and the second one to select the option

Thanks for your branch Giulio, I approve it, but address Bartosz comment, he will topapprove this when he think is ready :-)

review: Approve

[Alan Pope 🍺🐧🐱 🦄 (popey)]

This looks great! I like the swipe copy feature!

[lp:~gcollura/ubuntu-calculator-app/swipe-copy-button-improvements]

77. By Giulio Collura on 2015-01-23

remove change of button sizes in this mp

[Giulio Collura (gcollura)]

I'm moving the code to fix button height to another MP, since changing the ratio isn't the solution.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:77
http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/291/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid/816
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/816/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calculator-app-vivid-amd64-ci/13

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/291/rebuild

review: Approve (continuous-integration)

[Bartosz Kosiorek (gang65)]

Thanks Giulio.

review: Approve

=== modified file 'app/ubuntu-calculator-app.qml'
--- app/ubuntu-calculator-app.qml	2015-01-22 17:37:01 +0000
+++ app/ubuntu-calculator-app.qml	2015-01-23 13:33:15 +0000
@@ -221,6 +221,7 @@
         visible: true
         useDeprecatedToolbar: false
         property color dividerColor: "#babbbc"
+        property color panelColor: "white"
         config: PageHeadConfiguration {
             backAction: Action {
                 objectName: "cancelSelectionAction"
@@ -230,13 +231,6 @@
             }
             actions: [
                 Action {
-                    id: copySelectedAction
-                    objectName: "copySelectedAction"
-                    iconName: "edit-copy"
-                    text: i18n.tr("Copy")
-                    onTriggered: copySelectedCalculations()
-                },
-                Action {
                     id: selectAllAction
                     objectName: "selectAllAction"
                     iconName: "select"
@@ -244,6 +238,13 @@
                     onTriggered: visualModel.selectAll()
                 },
                 Action {
+                    id: copySelectedAction
+                    objectName: "copySelectedAction"
+                    iconName: "edit-copy"
+                    text: i18n.tr("Copy")
+                    onTriggered: copySelectedCalculations()
+                },
+                Action {
                     id: multiDeleteAction
                     objectName: "multiDeleteAction"
                     iconName: "delete"
@@ -300,9 +301,23 @@
                 visualModel.selectItem(visualDelegate);
             }
 
+            rightSideActions: [ screenDelegateCopyAction.item ]
             leftSideAction: screenDelegateDeleteAction.item
 
             Loader {
+                id: screenDelegateCopyAction
+                sourceComponent: Action {
+                    iconName: "edit-copy"
+                    text: i18n.tr("Copy")
+                    onTriggered: {
+                        var mimeData = Clipboard.newData();
+                        mimeData.text = model.formula + "=" + model.result;
+                        Clipboard.push(mimeData);
+                    }
+                }
+            }
+
+            Loader {
                 id: screenDelegateDeleteAction
                 sourceComponent: Action {
                     iconName: "delete"

=== modified file 'app/ui/KeyboardButton.qml'
--- app/ui/KeyboardButton.qml	2015-01-06 19:52:00 +0000
+++ app/ui/KeyboardButton.qml	2015-01-23 13:33:15 +0000
@@ -44,13 +44,19 @@
         border.color: "#bdbec0"
         border.width: units.dp(2)
         color: buttonMA.pressed || buttonRect.kbdPressed ? pressedColor : buttonColor
+
+        Behavior on color {
+            ColorAnimation {
+                duration: UbuntuAnimation.SnapDuration
+            }
+        }
     }
 
     Text {
         id: buttonText
         anchors.centerIn: parent
         color: "#5a5a5c"
-        font.pixelSize: 0.5 * parent.height 
+        font.pixelSize: 0.5 * parent.height
         font.bold: true
     }