Code review comment for lp:~gary/launchpadlib/reenable_tests

Revision history for this message
Francis J. Lacoste (flacoste) wrote :

On March 24, 2009, Gary Poster wrote:
> Gary Poster has proposed merging lp:~gary/launchpadlib/reenable_tests into
> lp:launchpadlib.
>
> Requested reviews:
> launchpadlib developers (launchpadlib-developers)
>
> This branch hooks up the new standalone launchpadlib tests with the
> buildout testrunner.
>
> It also nominally works with ``./setup.py test`` but it actually fails the
> first time you run it, and the succeeds subsequently. I didn't think it
> was worth investigating at this point in time.
>
> This also adds the ZPL license for the bootstrap code, and excludes the
> zc.buildout bits when you make a distribution.
>
> Finally, it updates the date of release for today, since I did not release
> it yesterday.

 status approved
 review approve

Looks good.

--
Francis J. Lacoste
<email address hidden>

review: Approve

« Back to merge proposal