Merge lp:~gary/launchpadlib/reenable_tests into lp:~launchpad-pqm/launchpadlib/devel

Proposed by Gary Poster
Status: Merged
Approved by: Francis J. Lacoste
Approved revision: 46
Merged at revision: not available
Proposed branch: lp:~gary/launchpadlib/reenable_tests
Merge into: lp:~launchpad-pqm/launchpadlib/devel
Diff against target: None lines
To merge this branch: bzr merge lp:~gary/launchpadlib/reenable_tests
Reviewer Review Type Date Requested Status
Francis J. Lacoste (community) Approve
Review via email: mp+4831@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Gary Poster (gary) wrote :

This branch hooks up the new standalone launchpadlib tests with the buildout testrunner.

It also nominally works with ``./setup.py test`` but it actually fails the first time you run it, and the succeeds subsequently. I didn't think it was worth investigating at this point in time.

This also adds the ZPL license for the bootstrap code, and excludes the zc.buildout bits when you make a distribution.

Finally, it updates the date of release for today, since I did not release it yesterday.

Revision history for this message
Francis J. Lacoste (flacoste) wrote :

On March 24, 2009, Gary Poster wrote:
> Gary Poster has proposed merging lp:~gary/launchpadlib/reenable_tests into
> lp:launchpadlib.
>
> Requested reviews:
> launchpadlib developers (launchpadlib-developers)
>
> This branch hooks up the new standalone launchpadlib tests with the
> buildout testrunner.
>
> It also nominally works with ``./setup.py test`` but it actually fails the
> first time you run it, and the succeeds subsequently. I didn't think it
> was worth investigating at this point in time.
>
> This also adds the ZPL license for the bootstrap code, and excludes the
> zc.buildout bits when you make a distribution.
>
> Finally, it updates the date of release for today, since I did not release
> it yesterday.

 status approved
 review approve

Looks good.

--
Francis J. Lacoste
<email address hidden>

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'MANIFEST.in'
2--- MANIFEST.in 1970-01-01 00:00:00 +0000
3+++ MANIFEST.in 2009-03-24 13:26:45 +0000
4@@ -0,0 +1,2 @@
5+exclude MANIFEST.in buildout.cfg bootstrap.py .bzrignore
6+prune _bootstrap
7
8=== modified file 'README.txt'
9--- README.txt 2009-03-23 21:50:35 +0000
10+++ README.txt 2009-03-23 22:48:16 +0000
11@@ -44,10 +44,3 @@
12 Please submit bug reports to
13
14 https://bugs.launchpad.net/launchpadlib
15-
16-
17-== Tests ==
18-
19-launchpadlib's test suite can be run using the nose test runner. It
20-should work simply running 'nosetests' from the directory where this
21-README file is located.
22
23=== added directory '_bootstrap'
24=== added file '_bootstrap/COPYRIGHT.txt'
25--- _bootstrap/COPYRIGHT.txt 1970-01-01 00:00:00 +0000
26+++ _bootstrap/COPYRIGHT.txt 2009-03-24 13:26:45 +0000
27@@ -0,0 +1,9 @@
28+Copyright (c) 2004-2009 Zope Corporation and Contributors.
29+All Rights Reserved.
30+
31+This software is subject to the provisions of the Zope Public License,
32+Version 2.1 (ZPL). A copy of the ZPL should accompany this distribution.
33+THIS SOFTWARE IS PROVIDED "AS IS" AND ANY AND ALL EXPRESS OR IMPLIED
34+WARRANTIES ARE DISCLAIMED, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
35+WARRANTIES OF TITLE, MERCHANTABILITY, AGAINST INFRINGEMENT, AND FITNESS
36+FOR A PARTICULAR PURPOSE.
37
38=== added file '_bootstrap/LICENSE.txt'
39--- _bootstrap/LICENSE.txt 1970-01-01 00:00:00 +0000
40+++ _bootstrap/LICENSE.txt 2009-03-24 13:26:45 +0000
41@@ -0,0 +1,54 @@
42+Zope Public License (ZPL) Version 2.1
43+-------------------------------------
44+
45+A copyright notice accompanies this license document that
46+identifies the copyright holders.
47+
48+This license has been certified as open source. It has also
49+been designated as GPL compatible by the Free Software
50+Foundation (FSF).
51+
52+Redistribution and use in source and binary forms, with or
53+without modification, are permitted provided that the
54+following conditions are met:
55+
56+1. Redistributions in source code must retain the
57+ accompanying copyright notice, this list of conditions,
58+ and the following disclaimer.
59+
60+2. Redistributions in binary form must reproduce the accompanying
61+ copyright notice, this list of conditions, and the
62+ following disclaimer in the documentation and/or other
63+ materials provided with the distribution.
64+
65+3. Names of the copyright holders must not be used to
66+ endorse or promote products derived from this software
67+ without prior written permission from the copyright
68+ holders.
69+
70+4. The right to distribute this software or to use it for
71+ any purpose does not give you the right to use
72+ Servicemarks (sm) or Trademarks (tm) of the copyright
73+ holders. Use of them is covered by separate agreement
74+ with the copyright holders.
75+
76+5. If any files are modified, you must cause the modified
77+ files to carry prominent notices stating that you changed
78+ the files and the date of any change.
79+
80+Disclaimer
81+
82+ THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS ``AS IS''
83+ AND ANY EXPRESSED OR IMPLIED WARRANTIES, INCLUDING, BUT
84+ NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY
85+ AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN
86+ NO EVENT SHALL THE COPYRIGHT HOLDERS BE
87+ LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
88+ EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
89+ LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
90+ LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
91+ HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
92+ CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE
93+ OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
94+ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
95+ DAMAGE.
96\ No newline at end of file
97
98=== renamed file 'bootstrap.py' => '_bootstrap/bootstrap.py'
99=== added symlink 'bootstrap.py'
100=== target is '_bootstrap/bootstrap.py'
101=== modified file 'buildout.cfg'
102--- buildout.cfg 2009-03-19 15:22:56 +0000
103+++ buildout.cfg 2009-03-23 22:48:16 +0000
104@@ -1,7 +1,7 @@
105 [buildout]
106 parts =
107 interpreter
108-# test
109+ test
110 # docs
111 tags
112 unzip = true
113
114=== modified file 'setup.py'
115--- setup.py 2009-03-20 20:46:06 +0000
116+++ setup.py 2009-03-23 22:48:16 +0000
117@@ -74,5 +74,5 @@
118 "Operating System :: OS Independent",
119 "Programming Language :: Python"],
120 setup_requires=['eggtestinfo', 'setuptools_bzr'],
121- # test_suite='launchpadlib.tests.test_suite',
122+ test_suite='launchpadlib.tests',
123 )
124
125=== modified file 'src/launchpadlib/NEWS.txt'
126--- src/launchpadlib/NEWS.txt 2009-03-21 11:39:22 +0000
127+++ src/launchpadlib/NEWS.txt 2009-03-24 13:31:09 +0000
128@@ -2,7 +2,7 @@
129 NEWS for launchpadlib
130 =====================
131
132-1.0 (2009-03-23)
133+1.0 (2009-03-24)
134 ================
135
136 - Initial release on PyPI
137
138=== modified file 'src/launchpadlib/tests/__init__.py'
139--- src/launchpadlib/tests/__init__.py 2009-02-25 09:34:02 +0000
140+++ src/launchpadlib/tests/__init__.py 2009-03-23 22:48:16 +0000
141@@ -0,0 +1,16 @@
142+# Copyright 2008 Canonical Ltd.
143+
144+# This file is part of launchpadlib.
145+#
146+# launchpadlib is free software: you can redistribute it and/or modify it
147+# under the terms of the GNU Lesser General Public License as published by the
148+# Free Software Foundation, version 3 of the License.
149+#
150+# launchpadlib is distributed in the hope that it will be useful, but WITHOUT
151+# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
152+# FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License
153+# for more details.
154+#
155+# You should have received a copy of the GNU Lesser General Public License
156+# along with launchpadlib. If not, see <http://www.gnu.org/licenses/>.
157+"""Tests for launchpadlib"""
158
159=== modified file 'src/launchpadlib/tests/test_credentials.py'
160--- src/launchpadlib/tests/test_credentials.py 2009-02-26 14:04:42 +0000
161+++ src/launchpadlib/tests/test_credentials.py 2009-03-23 22:48:16 +0000
162@@ -2,19 +2,17 @@
163
164 # This file is part of launchpadlib.
165 #
166-# launchpadlib is free software: you can redistribute it and/or modify
167-# it under the terms of the GNU Lesser General Public License as
168-# published by the Free Software Foundation, either version 3 of the
169-# License, or (at your option) any later version.
170-#
171-# launchpadlib is distributed in the hope that it will be useful, but
172-# WITHOUT ANY WARRANTY; without even the implied warranty of
173-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
174-# Lesser General Public License for more details.
175-#
176-# You should have received a copy of the GNU Lesser General Public
177-# License along with launchpadlib. If not, see
178-# <http://www.gnu.org/licenses/>.
179+# launchpadlib is free software: you can redistribute it and/or modify it
180+# under the terms of the GNU Lesser General Public License as published by the
181+# Free Software Foundation, version 3 of the License.
182+#
183+# launchpadlib is distributed in the hope that it will be useful, but WITHOUT
184+# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
185+# FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License
186+# for more details.
187+#
188+# You should have received a copy of the GNU Lesser General Public License
189+# along with launchpadlib. If not, see <http://www.gnu.org/licenses/>.
190
191 """Tests for the Credentials class."""
192
193@@ -57,3 +55,6 @@
194 loaded_credentials.access_token.key, 'access.key')
195 self.assertEqual(
196 loaded_credentials.access_token.secret, 'access.secret')
197+
198+def additional_tests():
199+ return unittest.TestLoader().loadTestsFromName(__name__)
200
201=== modified file 'src/launchpadlib/tests/test_launchpad.py'
202--- src/launchpadlib/tests/test_launchpad.py 2009-03-12 14:17:55 +0000
203+++ src/launchpadlib/tests/test_launchpad.py 2009-03-23 22:48:16 +0000
204@@ -2,19 +2,17 @@
205
206 # This file is part of launchpadlib.
207 #
208-# launchpadlib is free software: you can redistribute it and/or modify
209-# it under the terms of the GNU Lesser General Public License as
210-# published by the Free Software Foundation, either version 3 of the
211-# License, or (at your option) any later version.
212-#
213-# launchpadlib is distributed in the hope that it will be useful, but
214-# WITHOUT ANY WARRANTY; without even the implied warranty of
215-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
216-# Lesser General Public License for more details.
217-#
218-# You should have received a copy of the GNU Lesser General Public
219-# License along with launchpadlib. If not, see
220-# <http://www.gnu.org/licenses/>.
221+# launchpadlib is free software: you can redistribute it and/or modify it
222+# under the terms of the GNU Lesser General Public License as published by the
223+# Free Software Foundation, version 3 of the License.
224+#
225+# launchpadlib is distributed in the hope that it will be useful, but WITHOUT
226+# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
227+# FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License
228+# for more details.
229+#
230+# You should have received a copy of the GNU Lesser General Public License
231+# along with launchpadlib. If not, see <http://www.gnu.org/licenses/>.
232
233 """Tests for the Launchpad class."""
234
235@@ -205,3 +203,6 @@
236 os.path.join(launchpadlib_dir, 'api.example.com', 'cache')))
237 self.assertTrue(os.path.exists(
238 os.path.join(launchpadlib_dir, 'api.example.com', 'credentials')))
239+
240+def additional_tests():
241+ return unittest.TestLoader().loadTestsFromName(__name__)

Subscribers

People subscribed via source and target branches